Skip to content

Bug in RepositoriesEndPoint.GetDiff() and GetPatch()? #93

@asherber

Description

@asherber

I came across this while working on #90 .

Both GetDiff() and GetPatch() take an options parameter which is an object. Looking at the API here and here I think this parameter should be called spec and should just be a string; passing in a random object will cause errors.

In addition, GetDiff() should be able to take an object like ListParameters that provides context, path, ignore_whitespace, and binary.

I can put together a PR if you agree that these should be fixed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions