Reenable the unused lint, and cleanup unused

Author: MitMaro

src/application.rs

@@ -194,7 +194,7 @@ mod tests {
 	use super::*;
 	use crate::{
 		display::Size,
-		input::{Event, KeyCode, KeyEvent, KeyModifiers},
+		input::{KeyCode, KeyEvent, KeyModifiers},
 		module::Modules,
 		runtime::{Installer, RuntimeError},
 		test_helpers::{

src/components/choice/tests.rs

@@ -1,11 +1,7 @@
 use rstest::rstest;
 
 use super::*;
-use crate::{
-	assert_rendered_output,
-	input::StandardEvent,
-	test_helpers::{assertions::assert_rendered_output::AssertRenderOptions, with_view_state},
-};
+use crate::{assert_rendered_output, input::StandardEvent, test_helpers::with_view_state};
 
 #[derive(Clone, Debug, PartialEq)]
 enum TestAction {

src/components/search_bar/tests.rs

@@ -1,7 +1,11 @@
 use claims::{assert_none, assert_some_eq};
 
 use super::*;
-use crate::{assert_rendered_output, view::ViewData};
+use crate::{
+	assert_rendered_output,
+	test_helpers::assertions::assert_rendered_output::AssertRenderOptions,
+	view::ViewData,
+};
 
 fn create_view_data(search_bar: &SearchBar) -> ViewData {
 	let view_line = search_bar.build_view_line();

src/config/theme.rs

@@ -138,7 +138,7 @@ mod tests {
 
 	use super::*;
 	use crate::{
-		config::{ConfigErrorCause, InvalidColorError},
+		config::InvalidColorError,
 		test_helpers::{invalid_utf, with_git_config},
 	};
 

src/display.rs

@@ -1,3 +1,4 @@
+#![cfg_attr(test, allow(dead_code, unused_imports))]
 //! Git Interactive Rebase Tool - Display Module
 //!
 //! # Description

src/git/errors.rs

@@ -13,6 +13,7 @@ use thiserror::Error;
 pub(crate) enum RepositoryLoadKind {
 	/// Repository was loaded from the path provided through an environment variable
 	Environment,
+	#[cfg(test)]
 	/// Repository was loaded from a direct path
 	Path,
 }
@@ -21,6 +22,7 @@ impl Display for RepositoryLoadKind {
 	fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
 		match *self {
 			Self::Environment => write!(f, "environment"),
+			#[cfg(test)]
 			Self::Path => write!(f, "path"),
 		}
 	}
@@ -29,6 +31,7 @@ impl Display for RepositoryLoadKind {
 /// Git errors
 #[derive(Error, Debug, PartialEq)]
 #[non_exhaustive]
+#[allow(clippy::enum_variant_names)]
 pub(crate) enum GitError {
 	/// The repository could not be loaded
 	#[error("Could not open repository from {kind}")]
@@ -47,6 +50,7 @@ pub(crate) enum GitError {
 		cause: git2::Error,
 	},
 	/// The configuration could not be loaded
+	#[cfg(test)]
 	#[error("Could not load configuration")]
 	ReferenceNotFound {
 		/// The internal cause of the load error.

src/git/repository.rs

@@ -1,22 +1,11 @@
 use std::{
 	fmt::{Debug, Formatter},
-	path::{Path, PathBuf},
 	sync::Arc,
 };
 
-use git2::{Oid, Signature};
 use parking_lot::Mutex;
 
-use crate::git::{
-	Commit,
-	CommitDiff,
-	CommitDiffLoader,
-	CommitDiffLoaderOptions,
-	Config,
-	GitError,
-	Reference,
-	RepositoryLoadKind,
-};
+use crate::git::{CommitDiff, CommitDiffLoader, CommitDiffLoaderOptions, Config, GitError, RepositoryLoadKind};
 
 /// A light cloneable, simple wrapper around the `git2::Repository` struct
 #[derive(Clone)]
@@ -43,22 +32,6 @@ impl Repository {
 		})
 	}
 
-	/// Attempt to open an already-existing repository at `path`.
-	///
-	/// # Errors
-	/// Will result in an error if the repository cannot be opened.
-	pub(crate) fn open_from_path(path: &Path) -> Result<Self, GitError> {
-		let repository = git2::Repository::open(path).map_err(|e| {
-			GitError::RepositoryLoad {
-				kind: RepositoryLoadKind::Path,
-				cause: e,
-			}
-		})?;
-		Ok(Self {
-			repository: Arc::new(Mutex::new(repository)),
-		})
-	}
-
 	/// Load the git configuration for the repository.
 	///
 	/// # Errors
@@ -93,78 +66,6 @@ impl Repository {
 			.map_err(|e| GitError::CommitLoad { cause: e })?
 			.remove(0))
 	}
-
-	/// Find a reference by the reference name.
-	///
-	/// # Errors
-	/// Will result in an error if the reference cannot be found.
-	pub(crate) fn find_reference(&self, reference: &str) -> Result<Reference, GitError> {
-		let repo = self.repository.lock();
-		let git2_reference = repo
-			.find_reference(reference)
-			.map_err(|e| GitError::ReferenceNotFound { cause: e })?;
-		Ok(Reference::from(&git2_reference))
-	}
-
-	/// Find a commit by a reference name.
-	///
-	/// # Errors
-	/// Will result in an error if the reference cannot be found or is not a commit.
-	pub(crate) fn find_commit(&self, reference: &str) -> Result<Commit, GitError> {
-		let repo = self.repository.lock();
-		let git2_reference = repo
-			.find_reference(reference)
-			.map_err(|e| GitError::ReferenceNotFound { cause: e })?;
-		Commit::try_from(&git2_reference)
-	}
-
-	pub(crate) fn repo_path(&self) -> PathBuf {
-		self.repository.lock().path().to_path_buf()
-	}
-
-	pub(crate) fn head_id(&self, head_name: &str) -> Result<Oid, git2::Error> {
-		let repo = self.repository.lock();
-		let ref_name = format!("refs/heads/{head_name}");
-		let revision = repo.revparse_single(ref_name.as_str())?;
-		Ok(revision.id())
-	}
-
-	pub(crate) fn commit_id_from_ref(&self, reference: &str) -> Result<Oid, git2::Error> {
-		let repo = self.repository.lock();
-		let commit = repo.find_reference(reference)?.peel_to_commit()?;
-		Ok(commit.id())
-	}
-
-	pub(crate) fn add_path_to_index(&self, path: &Path) -> Result<(), git2::Error> {
-		let repo = self.repository.lock();
-		let mut index = repo.index()?;
-		index.add_path(path)
-	}
-
-	pub(crate) fn remove_path_from_index(&self, path: &Path) -> Result<(), git2::Error> {
-		let repo = self.repository.lock();
-		let mut index = repo.index()?;
-		index.remove_path(path)
-	}
-
-	pub(crate) fn create_commit_on_index(
-		&self,
-		reference: &str,
-		author: &Signature<'_>,
-		committer: &Signature<'_>,
-		message: &str,
-	) -> Result<(), git2::Error> {
-		let repo = self.repository.lock();
-		let tree = repo.find_tree(repo.index()?.write_tree()?)?;
-		let head = repo.find_reference(reference)?.peel_to_commit()?;
-		_ = repo.commit(Some("HEAD"), author, committer, message, &tree, &[&head])?;
-		Ok(())
-	}
-
-	#[cfg(test)]
-	pub(crate) fn repository(&self) -> Arc<Mutex<git2::Repository>> {
-		Arc::clone(&self.repository)
-	}
 }
 
 impl From<git2::Repository> for Repository {
@@ -183,10 +84,112 @@ impl Debug for Repository {
 	}
 }
 
+#[cfg(test)]
+mod tests {
+	use std::{
+		path::{Path, PathBuf},
+		sync::Arc,
+	};
+
+	use git2::{Oid, Signature};
+	use parking_lot::Mutex;
+
+	use crate::git::{Commit, GitError, Reference, Repository, RepositoryLoadKind};
+
+	impl Repository {
+		/// Attempt to open an already-existing repository at `path`.
+		///
+		/// # Errors
+		/// Will result in an error if the repository cannot be opened.
+		pub(crate) fn open_from_path(path: &Path) -> Result<Self, GitError> {
+			let repository = git2::Repository::open(path).map_err(|e| {
+				GitError::RepositoryLoad {
+					kind: RepositoryLoadKind::Path,
+					cause: e,
+				}
+			})?;
+			Ok(Self {
+				repository: Arc::new(Mutex::new(repository)),
+			})
+		}
+
+		/// Find a reference by the reference name.
+		///
+		/// # Errors
+		/// Will result in an error if the reference cannot be found.
+		pub(crate) fn find_reference(&self, reference: &str) -> Result<Reference, GitError> {
+			let repo = self.repository.lock();
+			let git2_reference = repo
+				.find_reference(reference)
+				.map_err(|e| GitError::ReferenceNotFound { cause: e })?;
+			Ok(Reference::from(&git2_reference))
+		}
+
+		/// Find a commit by a reference name.
+		///
+		/// # Errors
+		/// Will result in an error if the reference cannot be found or is not a commit.
+		pub(crate) fn find_commit(&self, reference: &str) -> Result<Commit, GitError> {
+			let repo = self.repository.lock();
+			let git2_reference = repo
+				.find_reference(reference)
+				.map_err(|e| GitError::ReferenceNotFound { cause: e })?;
+			Commit::try_from(&git2_reference)
+		}
+
+		pub(crate) fn repo_path(&self) -> PathBuf {
+			self.repository.lock().path().to_path_buf()
+		}
+
+		pub(crate) fn head_id(&self, head_name: &str) -> Result<Oid, git2::Error> {
+			let repo = self.repository.lock();
+			let ref_name = format!("refs/heads/{head_name}");
+			let revision = repo.revparse_single(ref_name.as_str())?;
+			Ok(revision.id())
+		}
+
+		pub(crate) fn commit_id_from_ref(&self, reference: &str) -> Result<Oid, git2::Error> {
+			let repo = self.repository.lock();
+			let commit = repo.find_reference(reference)?.peel_to_commit()?;
+			Ok(commit.id())
+		}
+
+		pub(crate) fn add_path_to_index(&self, path: &Path) -> Result<(), git2::Error> {
+			let repo = self.repository.lock();
+			let mut index = repo.index()?;
+			index.add_path(path)
+		}
+
+		pub(crate) fn remove_path_from_index(&self, path: &Path) -> Result<(), git2::Error> {
+			let repo = self.repository.lock();
+			let mut index = repo.index()?;
+			index.remove_path(path)
+		}
+
+		pub(crate) fn create_commit_on_index(
+			&self,
+			reference: &str,
+			author: &Signature<'_>,
+			committer: &Signature<'_>,
+			message: &str,
+		) -> Result<(), git2::Error> {
+			let repo = self.repository.lock();
+			let tree = repo.find_tree(repo.index()?.write_tree()?)?;
+			let head = repo.find_reference(reference)?.peel_to_commit()?;
+			_ = repo.commit(Some("HEAD"), author, committer, message, &tree, &[&head])?;
+			Ok(())
+		}
+
+		pub(crate) fn repository(&self) -> Arc<Mutex<git2::Repository>> {
+			Arc::clone(&self.repository)
+		}
+	}
+}
+
 // Paths in Windows makes these tests difficult, so disable
 #[cfg(all(unix, test))]
-mod tests {
-	use std::env::set_var;
+mod unix_tests {
+	use std::path::Path;
 
 	use claims::{assert_err_eq, assert_ok};
 	use git2::{ErrorClass, ErrorCode};

src/input/event_provider.rs

@@ -74,7 +74,7 @@ mod read_event_mocks {
 mod tests {
 	use std::{io, io::ErrorKind};
 
-	use crossterm::event::{KeyCode, KeyEvent, KeyModifiers, MouseButton};
+	use crossterm::event::{KeyCode, KeyModifiers, MouseButton};
 
 	use super::*;
 

src/input/standard_event.rs

@@ -2,6 +2,7 @@
 #[derive(Debug, PartialOrd, PartialEq, Eq, Clone, Copy)]
 #[non_exhaustive]
 pub(crate) enum StandardEvent {
+	#[allow(unused)]
 	/// The exit meta event.
 	Exit,
 	/// The kill meta event.

src/input/thread/state.rs

@@ -122,7 +122,6 @@ mod tests {
 	};
 
 	use super::*;
-	use crate::input::Event;
 
 	fn create_state() -> State {
 		State::new()