-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Smart Accounts Kit] Add Embedded Wallets guide #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bgravenorst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions, and spotted a couple of typos.
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.md
Outdated
Show resolved
Hide resolved
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.md
Outdated
Show resolved
Hide resolved
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.md
Outdated
Show resolved
Hide resolved
|
|
||
| # Use MetaMask Embdeded Wallets (Web3Auth) with MetaMask Smart Accounts | ||
|
|
||
| [MetaMask Embedded Wallets (Web3Auth)](/embedded-wallets/) provides a pluggable embedded wallet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a reason why you should choose our solution over a different embedded wallet solution, this may a place to promote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not prefer adding a section on why choose xyz in guides, I would prefer tutorial for that which can marketed. Also, anyone using Smart Accounts they must have already figured out what EW they want to use, because the first step towards development journey would be choosing a signer -> then thinking about using a smart account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep this for an open discussion, and revisit once we know what's the best way to promote.
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.md
Outdated
Show resolved
Hide resolved
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.md
Outdated
Show resolved
Hide resolved
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.md
Outdated
Show resolved
Hide resolved
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com>
Description
Issue(s) fixed
Part of #2424
Preview
Checklist
External contributor checklist
Note
Adds a guide for using MetaMask Embedded Wallets (Web3Auth) as a signer with Smart Accounts and links it in the sidebar.
smart-accounts-kit/guides/smart-accounts/signers/embedded-wallets.mdWeb3AuthProvider/WagmiProviderwith config, and creating a smart account viatoMetaMaskSmartAccountusing Wagmi's wallet client.guides/smart-accounts/signers/embedded-walletstogator-sidebar.jsunderConfigure signers.Written by Cursor Bugbot for commit fff2751. This will update automatically on new commits. Configure here.