-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Smart Accounts Kit] Add guide for Dynamic #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| ## Prerequisites | ||
|
|
||
| - Install [Yarn](https://yarnpkg.com/), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Install [Yarn](https://yarnpkg.com/), | |
| - Package manager such as [Yarn](https://yarnpkg.com/) or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldnt even bother mentioning yarn, given that the bash example is for npm, the "such as" can do the "go do this with yarn if that pleases you" part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, my laser focus! I would still just such as and mention 1 ... everyone has a fav, so the important part is "package manager"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We follow this pattern through out the docs and it's been working so far, so would prefer keeping same.
| ## Prerequisites | ||
|
|
||
| - Install [Yarn](https://yarnpkg.com/), | ||
| [npm](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm), or another package manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [npm](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm), or another package manager | |
| [npm](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already mentioned above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per comment
| View the complete code for this guide at [gator-examples repository](https://github.com/MetaMask/gator-examples/tree/main/examples/smart-accounts/signers/dynamic). | ||
|
|
||
| ## Prerequisites | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - [Node.js](https://nodejs.org/en/download/) | |
| - React app | |
| :::note | |
| This guide uses React. However, by installing different dependencies, developers are free to leverage other Dynamic-supported frameworks. | |
| ::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already mentioned, also react app is not Prerequisite. They can use any framework React, Next JS, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit for Node.js requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependencies presented in the guide are specifically related to react: @dynamic-labs/sdk-react-core
to use vue or alt, user must adjust, hence suggestion to make clear this is react example AND to state that other frameworks are supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sdk-react-core is supported for react and other frameworks built on top of it like next js, remix, gatsby, and many others. I'll try to add a note rather than a prerequisite that guide is created for frameworks based on react.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an info note at top of the guide to make sure readers are aware.
Co-authored-by: m4sterbunny <m4sterbunny@gmail.com>
bgravenorst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicks.
Co-authored-by: Byron Gravenorst <50852695+bgravenorst@users.noreply.github.com>

Description
Issue(s) fixed
Part of #2424
Preview
Checklist
External contributor checklist
Note
Adds a Dynamic signer guide and sidebar entry, and fixes Advanced Permissions docs by adding a Steps section.
smart-accounts-kit/guides/smart-accounts/signers/dynamic.md(setup with Dynamic + Wagmi, provider/config, create smart account).gator-sidebar.jswith a new "Configure signers" category linking toguides/smart-accounts/signers/dynamic.## Stepsheading in "Execute on a MetaMask user's behalf" (both versioned and unversioned) to fix TOC structure.Written by Cursor Bugbot for commit 9578808. This will update automatically on new commits. Configure here.