Fix opacity when the attribute is provided at page load, _opacity is

not set (setter not run), should return the attribute value if _opacity
is nullish.

Update to do list

Work in progress - BNG and Feature Links (BC link) seem to have
mutually exclusive solutions - zoomTo after changing projection on
map is necessary to inform Leaflet of the changed CRS (scale difference)
but the history gets messed up and the BC link doesn't quite render
(you have to generate a moveend on the map, then it'll draw).

Removed a section  of code from _handleLink that sets the map viewer
projection when there is a single map layer and it has a different projection
from that of the map BECAUSE this is handled by the MapMLLayer in
selectAlternateProjection and we don't want to trigger the promise
involved in disconnecting / reconnecting all map layers (happens when
mapml-viewer projection attribute changed callback happens).

Author: prushforth

src/layer.js

@@ -48,6 +48,7 @@ export class MapLayer extends HTMLElement {
   }
 
   get opacity() {
+    // use ?? since 0 is falsy, || would return rhs in that case
     return this._opacity ?? this.getAttribute('opacity');
   }
 
@@ -157,6 +158,8 @@ export class MapLayer extends HTMLElement {
                 opacity: this.opacity
               }
             );
+            this._attachedToMap();
+            this._validateDisabled();
             resolve();
           })
           .catch((error) => {
@@ -170,23 +173,20 @@ export class MapLayer extends HTMLElement {
           mapprojection: this.parentElement.projection,
           opacity: this.opacity
         });
-        resolve();
-      }
-    })
-      .then(() => {
         this._attachedToMap();
         this._validateDisabled();
-      })
-      .catch((e) => {
-        if (e.type === 'changeprojection') {
-          this.src = e.detail.href;
-        } else {
-          console.log(e);
-          this.dispatchEvent(
-            new CustomEvent('error', { detail: { target: this } })
-          );
-        }
-      });
+        resolve();
+      }
+    }).catch((e) => {
+      if (e.type === 'changeprojection') {
+        this.src = e.detail.href;
+      } else {
+        console.log(e);
+        this.dispatchEvent(
+          new CustomEvent('error', { detail: { target: this } })
+        );
+      }
+    });
   }
   _attachedToMap() {
     // set i to the position of this layer element in the set of layers

src/mapml-viewer.js

@@ -360,8 +360,12 @@ export class MapViewer extends HTMLElement {
               layersReady.push(reAttach.whenReady());
             }
             Promise.allSettled(layersReady).then(() => {
-              this.zoomTo(lat, lon, zoom);
+              // if don't do a zoomTo, the BNG experiment ends up at zoom=5 (incorrectly)
+              // BUT the feature link from Canada/BC to BCTILE layer works
+              // can have one but not both tbd
+              //
               this._resetHistory();
+              this.zoomTo(lat, lon, zoom);
               this._map.announceMovement.enable();
             });
           }

src/mapml/utils/Util.js

@@ -527,12 +527,6 @@ export var Util = {
       }
       if (!link.inPlace && newLayer)
         layer.whenReady().then(() => {
-          if (
-            newLayer &&
-            ['_parent', '_self'].includes(link.target) &&
-            layer.parentElement.querySelectorAll('layer-').length === 1
-          )
-            layer.parentElement.projection = layer._layer.getProjection();
           if (!layer.extent) {
             layer._layer._setLayerElExtent();
           }

test/e2e/layers/layerOpacityAttribute.test.js

@@ -17,33 +17,27 @@ test.describe('Adding Opacity Attribute to the Layer- Element', () => {
   });
 
   test('Setting Opacity Attibute to Layer- Element', async () => {
+    await page.pause();
     let opacity_attribute_value = await page.$eval(
       'body > mapml-viewer > layer-',
       (layer) => layer.getAttribute('opacity')
     );
-    if (!opacity_attribute_value) {
-      return;
-    } else {
-      let layer_opacity = await page.$eval(
-        'body > mapml-viewer > layer-',
-        (layer) => layer.opacity
-      );
-      expect(layer_opacity).toEqual(opacity_attribute_value);
-    }
+    let layer_opacity = await page.$eval(
+      'body > mapml-viewer > layer-',
+      (layer) => layer.opacity
+    );
+    expect(layer_opacity).toEqual(opacity_attribute_value);
   });
   test('Opacity Slider Value Test', async () => {
+    await page.pause();
     let opacity_slider_value = await page.$eval(
       'div > div.leaflet-control-container > div.leaflet-top.leaflet-right > div > section > div.leaflet-control-layers-overlays > fieldset > div:nth-child(2) > details > input[type=range]',
       (input) => input.value
     );
-    if (!opacity_slider_value) {
-      return;
-    } else {
-      let layer_opacity = await page.$eval(
-        'body > mapml-viewer > layer-',
-        (layer) => layer.opacity
-      );
-      expect(layer_opacity).toEqual(opacity_slider_value);
-    }
+    let layer_opacity = await page.$eval(
+      'body > mapml-viewer > layer-',
+      (layer) => layer.opacity
+    );
+    expect(layer_opacity).toEqual(opacity_slider_value);
   });
 });

todo-tests

@@ -1,19 +1,24 @@
- 23 failed
-    core\featureIndexOverlay.test.js:96:7 › Feature Index Overlay test › Feature index content is correct on moveend
-    core\featureIndexOverlay.test.js:112:7 › Feature Index Overlay test › Feature index overlay is hidden when empty, reticle still visible
-    core\featureNavigation.test.js:19:9 › Playwright Keyboard Navigation + Query Layer Tests › Arrow Key Navigable Tests › Tab focuses inline features
-    core\layerContextMenu.test.js:50:7 › Playwright Layer Context Menu Tests › Layer context menu copy layer
-
-    core\mapFeature.test.js:36:7 › Playwright MapFeature Custom Element Tests › MapFeature interactivity tests - feature is not in index order
-    core\mapFeature.test.js:177:7 › Playwright MapFeature Custom Element Tests › Default click method test
-    core\mapFeature.test.js:222:7 › Playwright MapFeature Custom Element Tests › Default focus method test
-    core\projectionChange.test.js:19:9 › Playwright Projection Change Tests › Linked Feature Projection Change Tests › _self Linked Feature Change To OSMTILE
-    core\projectionChange.test.js:57:9 › Playwright Projection Change Tests › Linked Feature Projection Change Tests › Debug components update with projection changes
-    core\reticle.test.js:19:9 › Playwright Keyboard Navigation + Query Layer Tests › Crosshair Reticle Tests › Crosshair hidden onload, shows on focus
-    layers\general\zoomLimit.js:17:9 › Playwright featureLayer (Static Features) Layer Tests › Map Zoom Limit Tests for featureLayer › Limit map zooming (zooming in)
-    layers\general\zoomLimit.js:41:9 › Playwright featureLayer (Static Features) Layer Tests › Map Zoom Limit Tests for featureLayer › Limit map zooming (zooming out)
-    layers\multipleQueryExtents.test.js:128:7 › Multiple Extent Query Tests › Only features from one extent are returned for queries inside its (non overlapping) bounds
-    layers\multipleQueryExtents.test.js:161:7 › Multiple Extent Query Tests › No features returned when queried outside of bounds of all extents
-    layers\queryableMapExtent.test.js:18:7 › Playwright Remote MapML with <map-extent> Tests › Query remote MapML document
-    layers\templatedImageLayer.test.js:68:7 › Playwright templatedImage Layer Tests › Templated image layer - remove previous image on moveend
-    mapml-viewer\customTCRS.test.js:46:7 › Playwright Custom TCRS Tests › Complex Custom TCRS, static features loaded, templated features loaded
+TODO
+
+
+experiments/linking/features - clicking on BC does not work, Ontario link not working
+experiments/vector tiles - not working
+experiments/custom-projections/Arctic-SDI/ Canada  link not working
+
+deal with flaky tests???
+
+core/featureIndexOverlay test is broken, integrate other PR
+
+get rid of 'foo' event
+split up and move createAndAdd functionality from onAdd to initialize + onAdd
+
+dynamically update layer bounds as features added/removed from it
+
+migrate some stuff from map-feature to FeatureLayer e.g. removeInFeatureList move it
+evaluate what belongs to what
+
+refactor FeatureLayer into subclasses for static features, query features, templated features, templated tile features
+
+add zoomend / layeradd event handler for FeatureLayer that checks what features should be rendered
+
+