Skip to content

Commit 00d0b29

Browse files
behacklchopan050
andauthored
make sure that if updating is suspended for a parent mobject, children are still updated (#4402)
Co-authored-by: Francisco Manríquez Novoa <49853152+chopan050@users.noreply.github.com>
1 parent 83bcafb commit 00d0b29

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

manim/mobject/mobject.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -892,16 +892,15 @@ def update(self, dt: float = 0, recursive: bool = True) -> Self:
892892
:meth:`get_updaters`
893893
894894
"""
895-
if self.updating_suspended:
896-
return self
897-
for updater in self.updaters:
898-
if "dt" in inspect.signature(updater).parameters:
899-
updater(self, dt)
900-
else:
901-
updater(self)
895+
if not self.updating_suspended:
896+
for updater in self.updaters:
897+
if "dt" in inspect.signature(updater).parameters:
898+
updater(self, dt)
899+
else:
900+
updater(self)
902901
if recursive:
903902
for submob in self.submobjects:
904-
submob.update(dt, recursive)
903+
submob.update(dt, recursive=recursive)
905904
return self
906905

907906
def get_time_based_updaters(self) -> list[TimeBasedUpdater]:

manim/mobject/opengl/opengl_mobject.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,12 +1515,11 @@ def init_updaters(self) -> None:
15151515
self.updating_suspended: bool = False
15161516

15171517
def update(self, dt: float = 0, recurse: bool = True) -> Self:
1518-
if not self.has_updaters or self.updating_suspended:
1519-
return self
1520-
for time_based_updater in self.time_based_updaters:
1521-
time_based_updater(self, dt)
1522-
for non_time_updater in self.non_time_updaters:
1523-
non_time_updater(self)
1518+
if self.has_updaters and not self.updating_suspended:
1519+
for time_based_updater in self.time_based_updaters:
1520+
time_based_updater(self, dt)
1521+
for non_time_updater in self.non_time_updaters:
1522+
non_time_updater(self)
15241523
if recurse:
15251524
for submob in self.submobjects:
15261525
submob.update(dt, recurse)

0 commit comments

Comments
 (0)