Removed meaningless code from the should_upgrade test.

Author: trollfot

httptools/parser/parser.pyx

@@ -152,7 +152,8 @@ cdef class HttpParser:
         return bool(cparser.http_should_keep_alive(self._cparser))
 
     def should_upgrade(self):
-        return bool(self._cparser.upgrade)
+        cdef cparser.http_parser* parser = self._cparser
+        return bool(parser.upgrade)
 
     def feed_data(self, data):
         cdef:

tests/test_parser.py

@@ -367,11 +367,12 @@ def on_message_complete(self):
         protocol = Protocol()
         try:
             protocol.parser.feed_data(UPGRADE_REQUEST1)
-        except httptools.HttpParserUpgrade as ex:
-            offset = ex.args[0]
+        except httptools.HttpParserUpgrade:
+            # Raise as usual.
+            pass
         else:
             self.fail('HttpParserUpgrade was not raised')
-        
+
     def test_parser_request_error_in_on_header(self):
         class Error(Exception):
             pass