From 2fe91a50bff9545825e4404164a0a1f82145270d Mon Sep 17 00:00:00 2001 From: pmocz Date: Thu, 4 Dec 2025 08:59:55 -0500 Subject: [PATCH 1/3] test new resid, scale fixed at beginning --- star/private/hydro_eqns.f90 | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/star/private/hydro_eqns.f90 b/star/private/hydro_eqns.f90 index 9cf261d41..f9cfb4334 100644 --- a/star/private/hydro_eqns.f90 +++ b/star/private/hydro_eqns.f90 @@ -1003,8 +1003,8 @@ subroutine set_Tsurf_BC(ierr) integer, intent(out) :: ierr logical :: test_partials type(auto_diff_real_star_order1) :: & - lnT1_ad, dT4_dm, T4_p1, T4_surf, T4_00_actual, T4_00_expected, scale - real(dp) :: residual + lnT1_ad, dT4_dm, T4_p1, T4_surf, T4_00_actual, T4_00_expected + real(dp) :: residual, scale include 'formats' !test_partials = (1 == s% solver_test_partials_k) test_partials = .false. @@ -1018,7 +1018,7 @@ subroutine set_Tsurf_BC(ierr) resid_ad = T4_00_expected/T4_00_actual - 1d0 else lnT1_ad = wrap_lnT_00(s,1) - scale = max(1d0,lnT1_ad) + scale = max(1d0,s%lnT_start(1)) resid_ad = (lnT_bc_ad - lnT1_ad)/scale end if residual = resid_ad%val @@ -1045,13 +1045,14 @@ end subroutine set_Tsurf_BC subroutine set_Psurf_BC(ierr) integer, intent(out) :: ierr logical :: test_partials - type(auto_diff_real_star_order1) :: lnP1_ad, scale + type(auto_diff_real_star_order1) :: lnP1_ad + real(dp) :: scale include 'formats' !test_partials = (1 == s% solver_test_partials_k) test_partials = .false. ierr = 0 lnP1_ad = wrap_lnPeos_00(s,1) - scale = max(1d0,lnP1_ad) + scale = max(1d0,s%lnPeos_start(1)) resid_ad = (lnP_bc_ad - lnP1_ad)/scale s% equ(i_P_eqn, 1) = resid_ad%val if (test_partials) then From 59be2807ea49b6754e2371dfae2e7e15d79fb911 Mon Sep 17 00:00:00 2001 From: Ebraheem Farag <63124736+Debraheem@users.noreply.github.com> Date: Fri, 5 Dec 2025 11:12:46 -0500 Subject: [PATCH 2/3] [ci optional] address thermohaline, full test --- star/test_suite/1M_thermohaline/inlist_1M_thermohaline | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/star/test_suite/1M_thermohaline/inlist_1M_thermohaline b/star/test_suite/1M_thermohaline/inlist_1M_thermohaline index 85298b49f..6cd5cc988 100644 --- a/star/test_suite/1M_thermohaline/inlist_1M_thermohaline +++ b/star/test_suite/1M_thermohaline/inlist_1M_thermohaline @@ -61,7 +61,7 @@ trace_history_value_name(3) = 'he_core_mass' ! limit max_model_number as part of test_suite - max_model_number = 6500 + max_model_number = 7000 initial_mass = 1.0 initial_z = 2d-2 From 36d38f727001b374160a11a72b5cf0aff9228102 Mon Sep 17 00:00:00 2001 From: Ebraheem Farag <63124736+Debraheem@users.noreply.github.com> Date: Mon, 8 Dec 2025 12:19:08 -0500 Subject: [PATCH 3/3] [ci optional] full test