-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add adapt_checkpoint_hparams hook for customizing checkpoint hyperparameter loading #21408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -560,6 +560,36 @@ def parse_arguments(self, parser: LightningArgumentParser, args: ArgsType) -> No | |
| else: | ||
| self.config = parser.parse_args(args) | ||
|
|
||
| def adapt_checkpoint_hparams(self, checkpoint_hparams: Dict[str, Any]) -> Dict[str, Any]: | ||
| """Adapt checkpoint hyperparameters before instantiating the model class. | ||
|
|
||
| This method allows for customization of hyperparameters loaded from a checkpoint when | ||
| using a different model class than the one used for training. For example, when loading | ||
| a checkpoint from a TrainingModule to use with an InferenceModule that has different | ||
| ``__init__`` parameters, you can remove or modify incompatible hyperparameters. | ||
|
|
||
| Args: | ||
| checkpoint_hparams: Dictionary of hyperparameters loaded from the checkpoint. | ||
|
|
||
| Returns: | ||
| Dictionary of adapted hyperparameters to be used for model instantiation. | ||
|
|
||
| Example:: | ||
|
|
||
| class MyCLI(LightningCLI): | ||
| def adapt_checkpoint_hparams(self, checkpoint_hparams: Dict[str, Any]) -> Dict[str, Any]: | ||
|
||
| # Remove training-specific hyperparameters not needed for inference | ||
| checkpoint_hparams.pop("lr", None) | ||
| checkpoint_hparams.pop("weight_decay", None) | ||
| return checkpoint_hparams | ||
|
|
||
| Note: | ||
| If subclass module mode is enabled and ``_class_path`` is present in the checkpoint | ||
| hyperparameters, you may need to modify it as well to point to your new module class. | ||
|
|
||
| """ | ||
| return checkpoint_hparams | ||
|
Comment on lines
+563
to
+591
|
||
|
|
||
| def _parse_ckpt_path(self) -> None: | ||
| """If a checkpoint path is given, parse the hyperparameters from the checkpoint and update the config.""" | ||
| if not self.config.get("subcommand"): | ||
|
|
@@ -571,6 +601,12 @@ def _parse_ckpt_path(self) -> None: | |
| hparams.pop("_instantiator", None) | ||
| if not hparams: | ||
| return | ||
|
|
||
| # Allow customization of checkpoint hyperparameters via adapt_checkpoint_hparams hook | ||
| hparams = self.adapt_checkpoint_hparams(hparams) | ||
| if not hparams: | ||
| return | ||
|
|
||
| if "_class_path" in hparams: | ||
| hparams = { | ||
| "class_path": hparams.pop("_class_path"), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use lowercase
dictinstead ofDictfor type annotations to align with the modern Python 3.9+ style used throughout this file. ChangeDict[str, Any]todict[str, Any]in both the parameter and return type annotations.