From d88737aaa534cabb709eabd146c45d3316445a2f Mon Sep 17 00:00:00 2001
From: Trey Chadick <tchad@labkey.com>
Date: Wed, 17 Dec 2025 10:17:21 -0800
Subject: [PATCH] Wait longer for QC metrics page to load (#1148)

---
 .../labkey/test/components/targetedms/QCPlotsWebPart.java  | 1 -
 .../test/components/targetedms/QCSummaryWebPart.java       | 1 -
 .../test/pages/panoramapremium/ConfigureMetricsUIPage.java | 7 ++++++-
 .../tests/targetedms/TargetedMSQCConfigureMetricTest.java  | 7 ++++++-
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/test/src/org/labkey/test/components/targetedms/QCPlotsWebPart.java b/test/src/org/labkey/test/components/targetedms/QCPlotsWebPart.java
index 4f8328dac..3660dd5a7 100644
--- a/test/src/org/labkey/test/components/targetedms/QCPlotsWebPart.java
+++ b/test/src/org/labkey/test/components/targetedms/QCPlotsWebPart.java
@@ -744,7 +744,6 @@ public Locator.XPathLocator getBubbleContent()
     public ConfigureMetricsUIPage clickConfigureQCMetrics()
     {
         clickMenuItem("Configure QC Metrics");
-        getWrapper().waitForElement(Locator.tagWithText("button", ConfigureMetricsUIPage.ADD_NEW_CUSTOM_METRIC));
         return new ConfigureMetricsUIPage(getDriver());
     }
 
diff --git a/test/src/org/labkey/test/components/targetedms/QCSummaryWebPart.java b/test/src/org/labkey/test/components/targetedms/QCSummaryWebPart.java
index ac95bbc8c..091625aa0 100644
--- a/test/src/org/labkey/test/components/targetedms/QCSummaryWebPart.java
+++ b/test/src/org/labkey/test/components/targetedms/QCSummaryWebPart.java
@@ -103,7 +103,6 @@ protected Elements newElementCache()
     public ConfigureMetricsUIPage clickConfigureQCMetrics()
     {
         clickMenuItem("Configure QC Metrics");
-        getWrapper().waitForElement(Locator.tagWithText("button", ConfigureMetricsUIPage.ADD_NEW_CUSTOM_METRIC));
         return new ConfigureMetricsUIPage(getDriver());
 
     }
diff --git a/test/src/org/labkey/test/pages/panoramapremium/ConfigureMetricsUIPage.java b/test/src/org/labkey/test/pages/panoramapremium/ConfigureMetricsUIPage.java
index bc5050327..991c55f4e 100644
--- a/test/src/org/labkey/test/pages/panoramapremium/ConfigureMetricsUIPage.java
+++ b/test/src/org/labkey/test/pages/panoramapremium/ConfigureMetricsUIPage.java
@@ -2,7 +2,6 @@
 
 import org.jetbrains.annotations.Nullable;
 import org.junit.Assert;
-import org.labkey.test.BaseWebDriverTest;
 import org.labkey.test.Locator;
 import org.labkey.test.components.ext4.Window;
 import org.labkey.test.components.targetedms.QCPlotsWebPart;
@@ -23,6 +22,12 @@ public ConfigureMetricsUIPage(WebDriver driver)
         super(driver);
     }
 
+    @Override
+    protected void waitForPage()
+    {
+        waitForElement(Locator.tagWithText("button", ConfigureMetricsUIPage.ADD_NEW_CUSTOM_METRIC), 15_000);
+    }
+
     public ConfigureMetricsUIPage setLeveyJennings(String metric, @Nullable String lowerBound, @Nullable String upperBound)
     {
         selectOptionByText(Locator.name(metric), "Levey-Jennings (+/- standard deviations)");
diff --git a/test/src/org/labkey/test/tests/targetedms/TargetedMSQCConfigureMetricTest.java b/test/src/org/labkey/test/tests/targetedms/TargetedMSQCConfigureMetricTest.java
index 85f3e4833..0a3d10953 100644
--- a/test/src/org/labkey/test/tests/targetedms/TargetedMSQCConfigureMetricTest.java
+++ b/test/src/org/labkey/test/tests/targetedms/TargetedMSQCConfigureMetricTest.java
@@ -11,7 +11,6 @@
 import org.labkey.test.pages.panoramapremium.ConfigureMetricsUIPage;
 import org.labkey.test.pages.targetedms.PanoramaDashboard;
 import org.labkey.test.tests.panoramapremium.TargetedMSPremiumTest;
-import org.labkey.test.util.DataRegion;
 import org.labkey.test.util.DataRegionTable;
 import org.openqa.selenium.WebElement;
 
@@ -114,6 +113,8 @@ public void testBadMetricQuery()
     @Test
     public void testFixedDeviationFromMeanOption()
     {
+        goToProjectHome();
+
         QCPlotsWebPart.MetricType metricType = QCPlotsWebPart.MetricType.TRANSITION_AREA;
         ConfigureMetricsUIPage configureQCMetrics = goToDashboard().getQcSummaryWebPart().clickConfigureQCMetrics();
 
@@ -153,6 +154,8 @@ public void testFixedDeviationFromMeanOption()
     @Test
     public void testFixedValueCutOffOption()
     {
+        goToProjectHome();
+
         QCPlotsWebPart.MetricType metric = QCPlotsWebPart.MetricType.TRANSITION_MASS_ERROR;
         ConfigureMetricsUIPage configureQCMetrics = goToDashboard().getQcSummaryWebPart().clickConfigureQCMetrics();
 
@@ -185,6 +188,8 @@ public void testFixedValueCutOffOption()
     @Test
     public void testPlotOnlyOption()
     {
+        goToProjectHome();
+
         QCPlotsWebPart.MetricType metric = QCPlotsWebPart.MetricType.ISOTOPE_DOTP;
         ConfigureMetricsUIPage configureQCMetrics = goToDashboard().getQcSummaryWebPart().clickConfigureQCMetrics();
         configureQCMetrics.setShowMetricNoOutlier(metric);