Integrate settings types into regular settings (#22)

Author: rcx

src/main/java/the/bytecode/club/jda/decompilers/FernflowerDecompiler.java

@@ -48,7 +48,7 @@ public FernflowerDecompiler() {
         settings.registerSetting(new SettingsEntry("udv", "Recover variable names", true));
         settings.registerSetting(new SettingsEntry("rer", "Remove empty exceptions", true));
         settings.registerSetting(new SettingsEntry("fdi", "De-inline finally", true));
-        settings.registerSetting(new SettingsEntry("mpm", "Maximum processing time", "0", Setting.SettingType.INT)); // this is a numeric setting!
+        settings.registerSetting(new SettingsEntry("mpm", "Maximum processing time", 0, Setting.SettingType.INT)); // this is a numeric setting!
         settings.registerSetting(new SettingsEntry("ren", "Rename ambigious members", false));
         // urc: IIDentifierRenamer
         settings.registerSetting(new SettingsEntry("inn", "Remove IntelliJ @NotNull", true));

src/main/java/the/bytecode/club/jda/settings/DecompilerSettings.java

@@ -140,7 +140,7 @@ public static class SettingsEntry extends Setting {
         public final String param;
 
         public SettingsEntry(String param, String key, Object value, SettingType type) {
-            super("todo lmao", key, value, type);
+            super(null, key, value, type);
             this.param = param;
         }
 

src/main/java/the/bytecode/club/jda/settings/Setting.java

@@ -1,40 +1,59 @@
 package the.bytecode.club.jda.settings;
 
+import static the.bytecode.club.jda.settings.Setting.SettingType.*;
+
 public class Setting {
     public final String node; //TODO: convert to JSON node or something
     public final String key;
     public final SettingType type;
     private Object value;
 
-    public Setting(String key, String value) {
-        this("settings", key, value, SettingType.STRING);
-    }
-
-    public Setting(String node, String key, Object value) {
-        this(node, key, value, SettingType.STRING);
-    }
-
     public Setting(String node, String key, Object value, SettingType type) {
         this.node = node;
         this.key = key;
         this.value = value;
         this.type = type;
     }
 
+    public Setting(String node, String key, Object value) {
+        this(node, key, value, STRING);
+    }
+
+    public Setting(String key, Object value, SettingType type) {
+        this("settings", key, value, type);
+    }
+
+    public Setting(String key, String value) {
+        this(key, (Object)value, STRING);
+    }
+
     public String get() {
         return value.toString();
     }
 
     public boolean getBool() {
-        return Boolean.parseBoolean(get());
+        return (boolean) value;
     }
 
     public int getInt() {
-        return Integer.parseInt(get());
+        return (int) value;
     }
 
     public void set(Object value) {
-        this.value = value.toString();
+        switch (type) {
+            case BOOLEAN:
+                this.value = value instanceof Boolean ? value : Boolean.parseBoolean(value.toString());
+                break;
+            case INT:
+                this.value = value instanceof Integer ? value : Integer.parseInt(value.toString());
+                break;
+            case OPTIONS:
+                throw new UnsupportedOperationException();
+            case STRING:
+            default:
+                this.value = value.toString();
+                break;
+        }
     }
 
     public boolean isEmpty() {

src/main/java/the/bytecode/club/jda/settings/Settings.java

@@ -14,6 +14,8 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import static the.bytecode.club.jda.settings.Setting.SettingType.*;
+
 /**
  * Used to handle loading/saving the GUI (options).
  *
@@ -24,14 +26,14 @@ public class Settings {
 
     // todo: I should really refactor this
     public static final Setting PATH = new Setting("path", "");
-    public static final Setting SHOW_CONTAINER_NAME = new Setting("showfilename", "false");
-    public static final Setting SNAP_TO_EDGES = new Setting("snaptoedges", "false");
-    public static final Setting DO_UPDATE_CHECK = new Setting("doupdatecheck", "true");
-    public static final Setting REFRESH_ON_VIEW_CHANGE = new Setting("refreshonviewchange", "false");
-
-    public static final Setting FONT_SIZE = new Setting("font", "fontsize", "12");
-    public static final Setting FONT_FAMILY = new Setting("font", "fontfamily", Font.MONOSPACED); // TODO: Doesn't save properly.
-    public static final Setting FONT_OPTIONS = new Setting("font", "fontoptions", String.valueOf(Font.PLAIN));
+    public static final Setting SHOW_CONTAINER_NAME = new Setting("showfilename", false, BOOLEAN);
+    public static final Setting SNAP_TO_EDGES = new Setting("snaptoedges", false, BOOLEAN);
+    public static final Setting DO_UPDATE_CHECK = new Setting("doupdatecheck", true, BOOLEAN);
+    public static final Setting REFRESH_ON_VIEW_CHANGE = new Setting("refreshonviewchange", false, BOOLEAN);
+
+    public static final Setting FONT_SIZE = new Setting("font", "fontsize", 12, INT);
+    public static final Setting FONT_FAMILY = new Setting("font", "fontfamily", Font.MONOSPACED);
+    public static final Setting FONT_OPTIONS = new Setting("font", "fontoptions", Font.PLAIN, INT);
 
     static
     {