test(AddVM) setup

Author: hoc081098

feature-add/build.gradle.kts

@@ -62,4 +62,5 @@ dependencies {
   implementation(deps.timber)
 
   addUnitTest()
+  testImplementation(mviTesting)
 }

feature-add/src/main/java/com/hoc/flowmvi/ui/add/AddContract.kt

@@ -62,7 +62,8 @@ internal sealed interface PartialStateChange {
   fun reduce(viewState: ViewState): ViewState
 
   data class ErrorsChanged(val errors: Set<ValidationError>) : PartialStateChange {
-    override fun reduce(viewState: ViewState) = viewState.copy(errors = errors)
+    override fun reduce(viewState: ViewState) =
+      if (viewState.errors == errors) viewState else viewState.copy(errors = errors)
   }
 
   sealed class AddUser : PartialStateChange {

feature-add/src/main/java/com/hoc/flowmvi/ui/add/AddVM.kt

@@ -168,10 +168,10 @@ class AddVM(
     }
 
     return merge(
+      formValuesChanges,
       errorsChanges,
       addUserChanges,
       firstChanges,
-      formValuesChanges,
     )
   }
 

feature-add/src/test/java/com/hoc/flowmvi/ui/add/AddVMTest.kt

@@ -0,0 +1,137 @@
+package com.hoc.flowmvi.ui.add
+
+import androidx.lifecycle.SavedStateHandle
+import com.flowmvi.mvi_testing.BaseMviViewModelTest
+import com.flowmvi.mvi_testing.mapRight
+import com.hoc.flowmvi.domain.usecase.AddUserUseCase
+import io.mockk.confirmVerified
+import io.mockk.mockk
+import kotlinx.coroutines.ExperimentalCoroutinesApi
+import kotlinx.coroutines.flow.flowOf
+import kotlin.test.Test
+import kotlin.time.ExperimentalTime
+
+private val ALL_ERRORS = ValidationError.values().toSet()
+
+@ExperimentalCoroutinesApi
+@ExperimentalTime
+class AddVMTest : BaseMviViewModelTest<ViewIntent, ViewState, SingleEvent, AddVM>() {
+  private lateinit var vm: AddVM
+  private lateinit var addUser: AddUserUseCase
+  private lateinit var savedStateHandle: SavedStateHandle
+
+  override fun setup() {
+    super.setup()
+
+    addUser = mockk()
+    savedStateHandle = SavedStateHandle()
+
+    vm = AddVM(
+      addUser = addUser,
+      savedStateHandle = savedStateHandle
+    )
+  }
+
+  override fun tearDown() {
+    confirmVerified(
+      addUser,
+    )
+
+    super.tearDown()
+  }
+
+  @Test
+  fun test_withFormValueIntents_returnsStateWithChangedValuesWithErrors() {
+    test(
+      vmProducer = { vm },
+      intents = flowOf(
+        ViewIntent.EmailChanged(""),
+        ViewIntent.FirstNameChanged(""),
+        ViewIntent.LastNameChanged(""),
+        // all fields changed
+        ViewIntent.EmailChanged("a"),
+        ViewIntent.FirstNameChanged("b"),
+        ViewIntent.LastNameChanged("c"),
+      ),
+      expectedStates = listOf(
+        ViewState.initial(
+          email = null,
+          firstName = null,
+          lastName = null,
+        ),
+        ViewState(
+          errors = emptySet(),
+          isLoading = false,
+          emailChanged = false,
+          firstNameChanged = false,
+          lastNameChanged = false,
+          email = "",
+          firstName = null,
+          lastName = null
+        ),
+        ViewState(
+          errors = emptySet(),
+          isLoading = false,
+          emailChanged = false,
+          firstNameChanged = false,
+          lastNameChanged = false,
+          email = "",
+          firstName = "",
+          lastName = null
+        ),
+        ViewState(
+          errors = emptySet(),
+          isLoading = false,
+          emailChanged = false,
+          firstNameChanged = false,
+          lastNameChanged = false,
+          email = "",
+          firstName = "",
+          lastName = ""
+        ),
+        ViewState(
+          errors = ALL_ERRORS,
+          isLoading = false,
+          emailChanged = false,
+          firstNameChanged = false,
+          lastNameChanged = false,
+          email = "",
+          firstName = "",
+          lastName = ""
+        ),
+        // all fields changed.
+        ViewState(
+          errors = ALL_ERRORS,
+          isLoading = false,
+          emailChanged = false,
+          firstNameChanged = false,
+          lastNameChanged = false,
+          email = "a",
+          firstName = "",
+          lastName = ""
+        ),
+        ViewState(
+          errors = ALL_ERRORS,
+          isLoading = false,
+          emailChanged = false,
+          firstNameChanged = false,
+          lastNameChanged = false,
+          email = "a",
+          firstName = "b",
+          lastName = ""
+        ),
+        ViewState(
+          errors = ALL_ERRORS,
+          isLoading = false,
+          emailChanged = false,
+          firstNameChanged = false,
+          lastNameChanged = false,
+          email = "a",
+          firstName = "b",
+          lastName = "c"
+        )
+      ).mapRight(),
+      expectedEvents = listOf(),
+    )
+  }
+}

feature-add/src/test/java/com/hoc/flowmvi/ui/add/ExampleUnitTest.kt

@@ -52,7 +52,7 @@ dependencies {
   implementation(deps.coroutines.core)
 
   implementation(mviBase)
-  implementation(testUtils)
+  api(testUtils)
   implementation(deps.timber)
 
   implementation(deps.arrow.core)

mvi/mvi-testing/build.gradle.kts

@@ -15,6 +15,7 @@ import kotlinx.coroutines.delay
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.collect
 import kotlinx.coroutines.flow.onCompletion
+import kotlinx.coroutines.flow.onEach
 import kotlinx.coroutines.flow.toList
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.test.runBlockingTest
@@ -63,7 +64,7 @@ abstract class BaseMviViewModelTest<
 
     val vm = vmProducer()
     intentsBeforeCollecting
-      ?.onCompletion { logIfEnabled { "---------------" } }
+      ?.onCompletion { logIfEnabled { "-".repeat(32) } }
       ?.collect {
         vm.processIntent(it)
         logIfEnabled { "[BEFORE] Dispatch $it -> $vm" }
@@ -74,15 +75,15 @@ abstract class BaseMviViewModelTest<
     val states = mutableListOf<S>()
     val events = mutableListOf<E>()
 
-    val stateJob = launch(start = CoroutineStart.UNDISPATCHED) { vm.viewState.toList(states) }
+    val stateJob = launch(start = CoroutineStart.UNDISPATCHED) { vm.viewState.onEach { logIfEnabled { "[STATE] <- $it" } }.toList(states) }
     val eventJob = launch(start = CoroutineStart.UNDISPATCHED) { vm.singleEvent.toList(events) }
 
     intents.collect {
-      vm.processIntent(it)
       logIfEnabled { "[DISPATCH] Dispatch $it -> $vm" }
+      vm.processIntent(it)
     }
     delay(delayAfterDispatchingIntents)
-    logIfEnabled { "---------------" }
+    logIfEnabled { "-".repeat(32) }
 
     logIfEnabled { "[DONE] states=${states.joinToStringWithIndex()}" }
     logIfEnabled { "[DONE] events=${events.joinToStringWithIndex()}" }