Skip to content

Commit d98ce57

Browse files
authored
deprecate nanosecondtime (#1895)
Co-authored-by: Johannes Terblanche <Affie@users.noreply.github.com>
1 parent df03471 commit d98ce57

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

IncrementalInference/src/services/FactorGraph.jl

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -558,10 +558,6 @@ $(SIGNATURES)
558558
559559
Add a variable node `label::Symbol` to `dfg::AbstractDFG`, as `varType<:StateType`.
560560
561-
Notes
562-
-----
563-
- keyword `nanosecondtime` is experimental and intended as the whole subsection portion -- i.e. accurateTime = (timestamp MOD second) + Nanosecond
564-
565561
Example
566562
-------
567563
@@ -577,14 +573,21 @@ function addVariable!(
577573
N::Int = getSolverParams(dfg).N,
578574
solvable::Int = 1,
579575
timestamp::Union{DateTime, ZonedDateTime} = now(localzone()),
580-
nanosecondtime::Union{Nanosecond, Int64, Nothing} = Nanosecond(0),
576+
nanosecondtime = nothing,
581577
# dontmargin::Bool = false,
582578
tags::Vector{Symbol} = Symbol[],
583579
smalldata = Dict{Symbol, DFG.MetadataTypes}(),
584580
checkduplicates::Bool = true,
585581
initsolvekeys::Vector{Symbol} = getSolverParams(dfg).algorithms,
586582
) where {T <: StateType}
587-
#
583+
584+
if !isnothing(nanosecondtime)
585+
Base.depwarn(
586+
"nanosecondtime kwarg is deprecated, use `timestamp` instead",
587+
:addVariable!,
588+
)
589+
end
590+
588591
varType = _variableType(varTypeU)
589592

590593
_zonedtime(s::DateTime) = ZonedDateTime(s, localzone())
@@ -598,7 +601,6 @@ function addVariable!(
598601
bloblets = smalldata,
599602
solvable = solvable,
600603
timestamp = _zonedtime(timestamp),
601-
steadytime = Nanosecond(nanosecondtime),
602604
)
603605

604606
(:default in initsolvekeys) && setDefaultNodeData!(

0 commit comments

Comments
 (0)