get hessian tests passing

Author: ajwheeler

src/b-splines/constant.jl

@@ -67,30 +67,36 @@ to `A[ceil(Int,x)]` without scaling.
 Constant
 
 function positions(c::Constant{Previous}, ax, x)  # discontinuity occurs at integer locations
-    xm = floorbounds(x, ax)
+    x_value = ForwardDiff.value(ForwardDiff.value(x))
+    xm = floorbounds(x_value, ax)
     δx = x - xm
     fast_trunc(Int, xm), δx
 end
 function positions(c::Constant{Next}, ax, x)  # discontinuity occurs at integer locations
-    xm = ceilbounds(x, ax)
+    x_value = ForwardDiff.value(ForwardDiff.value(x))
+    xm = ceilbounds(x_value, ax)
     δx = x - xm
     fast_trunc(Int, xm), δx
 end
 function positions(c::Constant{Nearest}, ax, x)  # discontinuity occurs at half-integer locations
-    xm = roundbounds(x, ax)
+    x_value = ForwardDiff.value(ForwardDiff.value(x))
+    xm = roundbounds(x_value, ax)
     δx = x - xm
-    fast_trunc(Int, xm), δx
+    i = fast_trunc(Int, xm)
+    i, δx
 end
 
 function positions(c::Constant{Previous,Periodic{OnCell}}, ax, x)
+    x_value = ForwardDiff.value(ForwardDiff.value(x))
     # We do not use floorbounds because we do not want to add a half at
     # the lowerbound to round up.
-    xm = floor(x)
+    xm = floor(x_value)
     δx = x - xm
     modrange(fast_trunc(Int, xm), ax), δx
 end
 function positions(c::Constant{Next,Periodic{OnCell}}, ax, x)  # discontinuity occurs at integer locations
-    xm = ceilbounds(x, ax)
+    x_value = ForwardDiff.value(ForwardDiff.value(x))
+    xm = ceilbounds(x_value, ax)
     δx = x - xm
     modrange(fast_trunc(Int, xm), ax), δx
 end

src/b-splines/indexing.jl

@@ -3,7 +3,7 @@
 itpinfo(itp) = (tcollect(itpflag, itp), axes(itp))
 
 @inline function (itp::BSplineInterpolation{T,N})(x::Vararg{Number,N}) where {T,N}
-    @boundscheck (checkbounds(Bool, itp, ForwardDiff.value.(x)...) || Base.throw_boundserror(itp, x))
+    @boundscheck (checkbounds(Bool, itp, ForwardDiff.value.(ForwardDiff.value.(x))...) || Base.throw_boundserror(itp, x))
     wis = weightedindexes((value_weights,), itpinfo(itp)..., x)
     InterpGetindex(itp)[wis...]
 end

src/b-splines/linear.jl

@@ -43,7 +43,7 @@ a piecewise linear function connecting each pair of neighboring data points.
 Linear
 
 function positions(deg::Linear, ax::AbstractUnitRange{<:Integer}, x)
-    x_value = ForwardDiff.value(x)
+    x_value = ForwardDiff.value(ForwardDiff.value(x))
     f = floor(x_value)
     # When x == last(ax) we want to use the x-1, x pair
     f = ifelse(x_value == last(ax), f - oneunit(f), f)

src/monotonic/monotonic.jl

@@ -207,8 +207,9 @@ function interpolate(
 end
 
 function (itp::MonotonicInterpolation)(x::Number)
-    @boundscheck (checkbounds(Bool, itp, x) || Base.throw_boundserror(itp, (x,)))
-    k = searchsortedfirst(itp.knots, x)
+    x_value = ForwardDiff.value(ForwardDiff.value(x))
+    @boundscheck (checkbounds(Bool, itp, x_value) || Base.throw_boundserror(itp, (x_value,)))
+    k = searchsortedfirst(itp.knots, x_value)
     if k > 1
         k -= 1
     end

test/runtests.jl

@@ -11,7 +11,9 @@ using Interpolations
 const isci = get(ENV, "CI", "") in ("true", "True")
 
 @testset "Interpolations" begin
-    @test isempty(detect_ambiguities(Interpolations))
+    @testset "method ambiguities" begin
+        @test isempty(detect_ambiguities(Interpolations))
+    end
 
     include("core.jl")
     # Hermite interpolation tests