Fixed serialisation bug by avoiding using the raw buffer

The raw buffer is sometimes expanded for performance reasons, which leaves the buffer with additional zeros. This fix just returns the written bytes of the PipeBuffer, instead of including the extra padding.

Author: JamieMair

src/event.jl

@@ -29,17 +29,16 @@ format. The format follows the following rule (in bytes)
 #4 N..N+8      UInt32  masked_CRC of #3
 """
 function write_event(out::IO, event::Event)
-    data = PipeBuffer();
-    encode(ProtoEncoder(data), event)
+    event_bytes = serialize_proto(event)
 
     #header
-    header     = collect(reinterpret(UInt8, [data.size]))
+    header     = collect(reinterpret(UInt8, [length(event_bytes)]))
     crc_header = reinterpret(UInt8, UInt32[masked_crc32c(header)])
-    crc_data   = reinterpret(UInt8, UInt32[masked_crc32c(data.data)])
+    crc_data   = reinterpret(UInt8, UInt32[masked_crc32c(event_bytes)])
 
     write(out, header)
     write(out, crc_header)
-    write(out, data.data)
+    write(out, event_bytes)
     write(out, crc_data)
     flush(out)
 end

src/utils.jl

@@ -9,7 +9,7 @@ end
 function serialize_proto(data)
     pb = PipeBuffer()
     encode(ProtoEncoder(pb), data)
-    pb.data
+    return view(pb.data, 1:pb.size) # Do not return additional zeros
 end
 
 """