Apply suggestions from code review

Co-authored-by: Frames White <oxinabox@ucc.asn.au>

Author: nomadbl

gen/compile_proto.jl

@@ -38,8 +38,6 @@ function process_module(cur_module::AbstractString; base_module::AbstractString=
     infiles = split.(string.(glob("*.proto", src_dir/input_path)), '/') .|> (a -> a[3:end]) .|> a -> joinpath(a...)
 
     mkpath(module_out_dir)
-    strip_currdir(str::String) = string(strip(str, ['.','/']))
-    # relative_paths = string.(infiles) .|> strip_currdir
     relative_paths = string.(infiles)
     search_directories = joinpath(@__DIR__, "proto")
     output_directory = string(module_out_dir)

src/Deserialization/deserialization.jl

@@ -250,12 +250,8 @@ function map_summaries(fun::Function, logdir; purge=true, tags=nothing, steps=no
             steps !== nothing && step ∉ steps && continue
 
             iter = SummaryDeserializingIterator(event.what.value, smart)
-            # fullnames = String[]
             for (name, val) in iter
                 tags !== nothing && name ∉ tags && continue
-                # fullname = "$(name)_$(step)"
-                # fullname in fullnames ? continue : push!(fullnames, fullname)
-
                 fun(name, step, val)
             end
         end

src/Deserialization/images.jl

@@ -14,7 +14,7 @@ function lookahead_deserialize_image_summary(old_tag, old_val, evs::Summary,
 
     state = state_old + 1
     iter_result = iterate(evs, state)
-    while !(iter_result isa Nothing)
+    while iter_result !== nothing
         ((tag, summary), state) = iter_result
         # iteration body
         typ = summary_type(summary)