Skip to content

Make stats tests numerically more stable for oneAPI #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michel2323 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make stats tests numerically more stable for oneAPI #662

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fcab28
Make stats tests numerically more stable
invalid-email-address Nov 26, 2025
3c72140
oneAPI ComplexF32 still not fixed :-(
invalid-email-address Nov 26, 2025
cc9cdae
Runiced
invalid-email-address Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 28 additions & 30 deletions test/testsuite/statistics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,33 @@ using Statistics
if !(ET in [Float16, Float32, Float64])
continue
end
range = ET <: Real ? (ET(1):ET(100)) : ET

@testset "std" begin
@test compare(std, AT, rand(ET, 10))
@test compare(std, AT, rand(ET, 10,1,2))
@test compare(A->std(A; corrected=true), AT, rand(ET, 10,1,2))
@test compare(A->std(A; dims=1), AT, rand(ET, 10,1,2))
@test compare(std, AT, rand(range, 10))
@test compare(std, AT, rand(range, 10, 1, 2))
@test compare(A -> std(A; corrected = true), AT, rand(range, 10, 1, 2))
@test compare(A -> std(A; dims = 1), AT, rand(range, 10, 1, 2))
end

@testset "var" begin
@test compare(var, AT, rand(ET, 10))
@test compare(var, AT, rand(ET, 10,1,2))
@test compare(A->var(A; corrected=true), AT, rand(ET, 10,1,2))
@test compare(A->var(A; dims=1), AT, rand(ET, 10,1,2))
@test compare(A->var(A; dims=[1]), AT, rand(ET, 10,1,2))
@test compare(A->var(A; dims=(1,)), AT, rand(ET, 10,1,2))
@test compare(A->var(A; dims=[2,3]), AT, rand(ET, 10,1,2))
@test compare(A->var(A; dims=(2,3)), AT, rand(ET, 10,1,2))
@test compare(var, AT, rand(range, 10))
@test compare(var, AT, rand(range, 10, 1, 2))
@test compare(A -> var(A; corrected = true), AT, rand(range, 10, 1, 2))
@test compare(A -> var(A; dims = 1), AT, rand(range, 10, 1, 2))
@test compare(A -> var(A; dims = [1]), AT, rand(range, 10, 1, 2))
@test compare(A -> var(A; dims = (1,)), AT, rand(range, 10, 1, 2))
@test compare(A -> var(A; dims = [2, 3]), AT, rand(range, 10, 1, 2))
@test compare(A -> var(A; dims = (2, 3)), AT, rand(range, 10, 1, 2))
end

@testset "mean" begin
@test compare(mean, AT, rand(ET, 2, 2))
@test compare(A->mean(A; dims=2), AT, rand(ET, 2, 2))
@test compare(A->mean(A; dims=[1,3]), AT, rand(ET, 2, 2, 2))
@test compare(A->mean(sin, A), AT, rand(ET, 2,2))
@test compare(A->mean(sin, A; dims=2), AT, rand(ET, 2,2))
@test compare(A->mean(sin, A; dims=[1,3]), AT, rand(ET, 2,2,2))
@test compare(mean, AT, rand(range, 2, 2))
@test compare(A -> mean(A; dims = 2), AT, rand(range, 2, 2))
@test compare(A -> mean(A; dims = [1, 3]), AT, rand(range, 2, 2, 2))
@test compare(A -> mean(sin, A), AT, rand(range, 2, 2))
@test compare(A -> mean(sin, A; dims = 2), AT, rand(range, 2, 2))
@test compare(A -> mean(sin, A; dims = [1, 3]), AT, rand(range, 2, 2, 2))
end
end

Expand All @@ -38,24 +40,20 @@ using Statistics
if !(ET in [Float32, Float64, Float16, ComplexF64])
continue
end
range = ET <: Real ? (ET(1):ET(100)) : ET

@testset "cov" begin
s = 100
@test compare(cov, AT, rand(ET, s))
@test compare(cov, AT, rand(ET, s, 2))
@test compare(A->cov(A; dims=2), AT, rand(ET, s, 2))
if ET <: Real
@test compare(cov, AT, rand(ET(1):ET(100), s))
end
@test compare(cov, AT, rand(range, s))
@test compare(cov, AT, rand(range, s, 2))
@test compare(A -> cov(A; dims = 2), AT, rand(range, s, 2))
end

@testset "cor" begin
s = 100
@test compare(cor, AT, rand(ET, s)) nans=true
@test compare(cor, AT, rand(ET, s, 2)) nans=true
@test compare(A->cor(A; dims=2), AT, rand(ET, s, 2)) nans=true
if ET <: Real
@test compare(cor, AT, rand(ET(1):ET(100), s)) nans=true
end
@test compare(cor, AT, rand(range, s)) nans = true
@test compare(cor, AT, rand(range, s, 2)) nans = true
@test compare(A -> cor(A; dims = 2), AT, rand(range, s, 2)) nans = true
end
end
end
Loading