add analyze kwarg to load! (#208)

* add analyze kwarg to load!

Author: kescobo

Project.toml

@@ -5,12 +5,12 @@ version = "1.0.2"
 
 [deps]
 BinaryProvider = "b99e7846-7c00-51b0-8f62-c81ae34c0232"
-Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
 DBInterface = "a10d1c49-ce27-4219-8d33-6db1a4562965"
+Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
 Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
-Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
 SQLite_jll = "76ed43ae-9a5d-5a62-8c75-30186b810ce8"
+Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
 Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 WeakRefStrings = "ea10d353-3f73-51f8-a26c-33c1cb351aa5"

src/tables.jl

@@ -120,13 +120,14 @@ function createtable!(db::DB, nm::AbstractString, ::Tables.Schema{names, types};
 end
 
 """
-    source |> SQLite.load!(db::SQLite.DB, tablename::String; temp::Bool=false, ifnotexists::Bool=false)
-    SQLite.load!(source, db, tablename; temp=false, ifnotexists=false)
+    source |> SQLite.load!(db::SQLite.DB, tablename::String; temp::Bool=false, ifnotexists::Bool=false, analyze::Bool=false)
+    SQLite.load!(source, db, tablename; temp=false, ifnotexists=false, analyze::Bool=false)
 
 Load a Tables.jl input `source` into an SQLite table that will be named `tablename` (will be auto-generated if not specified).
 
 `temp=true` will create a temporary SQLite table that will be destroyed automatically when the database is closed
 `ifnotexists=false` will throw an error if `tablename` already exists in `db`
+`analyze=true` will execute `ANALYZE` at the end of the insert
 """
 function load! end
 
@@ -143,7 +144,7 @@ end
 
 checkdupnames(names) = length(unique(map(x->lowercase(String(x)), names))) == length(names) || error("duplicate case-insensitive column names detected; sqlite doesn't allow duplicate column names and treats them case insensitive")
 
-function load!(sch::Tables.Schema, rows, db::DB, nm::AbstractString, name, shouldcreate; temp::Bool=false, ifnotexists::Bool=false)
+function load!(sch::Tables.Schema, rows, db::DB, nm::AbstractString, name, shouldcreate; temp::Bool=false, ifnotexists::Bool=false, analyze::Bool=false)
     # check for case-insensitive duplicate column names (sqlite doesn't allow)
     checkdupnames(sch.names)
     # create table if needed
@@ -161,12 +162,12 @@ function load!(sch::Tables.Schema, rows, db::DB, nm::AbstractString, name, shoul
             sqlite3_reset(stmt.handle)
         end
     end
-    execute(db, "ANALYZE $nm")
+    analyze && execute(db, "ANALYZE $nm")
     return name
 end
 
 # unknown schema case
-function load!(::Nothing, rows, db::DB, nm::AbstractString, name, shouldcreate; temp::Bool=false, ifnotexists::Bool=false)
+function load!(::Nothing, rows, db::DB, nm::AbstractString, name, shouldcreate; temp::Bool=false, ifnotexists::Bool=false, analyze::Bool=false)
     state = iterate(rows)
     state === nothing && return nm
     row, st = state
@@ -191,6 +192,7 @@ function load!(::Nothing, rows, db::DB, nm::AbstractString, name, shouldcreate;
             row, st = state
         end
     end
-    execute(db, "ANALYZE $nm")
+    analyze && execute(db, "ANALYZE $nm")
+
     return name
 end

test/runtests.jl

@@ -177,7 +177,7 @@ SQLite.drop!(db2, "nonexistant", ifexists=true)
 SQLite.drop!(db2, "tab2", ifexists=true)
 @test !in("tab2", SQLite.tables(db2)[1])
 
-SQLite.drop!(db, "sqlite_stat1")
+SQLite.drop!(db, "sqlite_stat1", ifexists=true)
 tables = SQLite.tables(db)
 @test length(tables[1]) == 11