test transforms using AFOP (#141)

Author: jishnub

Project.toml

@@ -29,6 +29,7 @@ ToeplitzMatrices = "c751599d-da0a-543b-9d20-d0a503d91d24"
 
 [compat]
 AbstractFFTs = "0.5, 1"
+ApproxFunOrthogonalPolynomials = "0.4"
 BandedMatrices = "0.16, 0.17"
 BlockArrays = "0.14, 0.15, 0.16"
 BlockBandedMatrices = "0.10, 0.11"
@@ -50,7 +51,8 @@ ToeplitzMatrices = "0.6, 0.7"
 julia = "1.5"
 
 [extras]
+ApproxFunOrthogonalPolynomials = "b70543e2-c0d9-56b8-a290-0d4d6d4de211"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 
 [targets]
-test = ["Random"]
+test = ["ApproxFunOrthogonalPolynomials", "Random"]

src/Space.jl

@@ -384,11 +384,13 @@ function CanonicalTransformPlan(space,v)
     csp = canonicalspace(space)
     CanonicalTransformPlan(eltype(v),space,plan_transform(csp,v),csp)
 end
-function plan_transform(sp::Space,vals)
+function checkcanonicalspace(sp)
     csp = canonicalspace(sp)
-    if sp == csp
-        error("Override for $sp")
-    end
+    sp == csp && error("Override for $sp")
+    csp
+end
+function plan_transform(sp::Space,vals)
+    csp = checkcanonicalspace(sp)
     CanonicalTransformPlan(sp,plan_transform(csp,vals),csp)
 end
 
@@ -398,10 +400,7 @@ function ICanonicalTransformPlan(space,v)
     ICanonicalTransformPlan(eltype(v),space,plan_itransform(csp,cfs),csp)
 end
 function plan_itransform(sp::Space,v)
-    csp = canonicalspace(sp)
-    if sp == csp
-        error("Override for $sp")
-    end
+    csp = checkcanonicalspace(sp)
     cfs = coefficients(v,sp,csp)
     ICanonicalTransformPlan(sp,plan_itransform(csp,cfs),csp)
 end

test/SpacesTest.jl

@@ -1,5 +1,6 @@
 using ApproxFunBase, Test
 import ApproxFunBase: PointSpace, HeavisideSpace, PiecewiseSegment, dimension, Vec, checkpoints
+using ApproxFunOrthogonalPolynomials
 
 @testset "Spaces" begin
     @testset "PointSpace" begin
@@ -165,4 +166,10 @@ import ApproxFunBase: PointSpace, HeavisideSpace, PiecewiseSegment, dimension, V
             @test union(b, b) == b
         end
     end
+
+    @testset "ApproxFunOrthogonalPolynomials" begin
+        v = rand(4)
+        v2 = transform(NormalizedChebyshev(), v)
+        @test itransform(NormalizedChebyshev(), v2) ≈ v
+    end
 end