fix(vector): Correct FAISS index training and search locking

This commit addresses two critical issues in the `faiss_manager.rs` file to improve correctness and performance.

First, it fixes a bug where the FAISS index was not being trained before vectors were added. This is a required step for many index types (e.g., IVF) and would lead to runtime crashes. The code now checks if the index is trained and, if not, trains it on the first batch of vectors that meets the training threshold.

Second, it resolves a performance bottleneck in concurrent search scenarios. The `search` function was taking a write lock on the index, which unnecessarily serialized all search operations. This has been changed to a read lock, allowing for concurrent searches and significantly improving throughput in multi-threaded environments.

Author: google-labs-jules[bot]

crates/codegraph-vector/src/faiss_manager.rs

@@ -75,16 +75,25 @@ impl SimpleFaissManager {
             return Ok(());
         }
 
-        // Prepare flat vector array for FAISS
         let flat_vectors: Vec<f32> = vectors
             .iter()
             .flat_map(|(_, embedding)| embedding.iter().cloned())
             .collect();
 
-        // Add to FAISS index
         let mut index_guard = self.index.write();
         let index = index_guard.as_mut().unwrap();
 
+        // CRITICAL FIX: Train the index if it's not already trained
+        if !index.is_trained() && vectors.len() >= self.config.training_threshold {
+            info!(
+                "Training FAISS index with {} vectors...",
+                flat_vectors.len() / self.config.dimension
+            );
+            index
+                .train(&flat_vectors)
+                .map_err(|e| CodeGraphError::Vector(format!("Failed to train index: {}", e)))?;
+        }
+
         index
             .add(&flat_vectors)
             .map_err(|e| CodeGraphError::Vector(format!("Failed to add vectors: {}", e)))?;
@@ -119,9 +128,10 @@ impl SimpleFaissManager {
             )));
         }
 
-        let mut index_guard = self.index.write();
+        // Use a read lock for concurrent searches
+        let index_guard = self.index.read();
         let index = index_guard
-            .as_mut()
+            .as_ref()
             .ok_or_else(|| CodeGraphError::Vector("Index not initialized".to_string()))?;
 
         let search_result = index