Skip to content

Commit 5630a7a

Browse files
refs #408: upgrade dependencies (#409)
1 parent 87d6e9e commit 5630a7a

File tree

37 files changed

+168
-78
lines changed

37 files changed

+168
-78
lines changed

build.gradle.kts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import com.jashmore.gradle.JacocoCoverallsPlugin
22
import com.jashmore.gradle.ReleasePlugin
33
import com.jashmore.gradle.release
4-
import io.gitlab.arturbosch.detekt.detekt
54

65
plugins {
76
java
@@ -12,7 +11,6 @@ plugins {
1211
id("com.github.spotbugs")
1312
id("com.jashmore.gradle.github.release")
1413
id("org.jlleitschuh.gradle.ktlint") apply false
15-
id("io.gitlab.arturbosch.detekt") apply false
1614
id("org.unbroken-dome.test-sets") version "4.0.0"
1715
}
1816

@@ -46,7 +44,6 @@ subprojects {
4644
}
4745
} else {
4846
apply(plugin = "org.jlleitschuh.gradle.ktlint")
49-
apply(plugin = "io.gitlab.arturbosch.detekt")
5047
}
5148

5249
dependencies {
@@ -86,12 +83,6 @@ subprojects {
8683
excludeFilter.set(file("${project.rootDir}/configuration/spotbugs/bugsExcludeFilter.xml"))
8784
}
8885
}
89-
} else {
90-
detekt {
91-
failFast = true
92-
buildUponDefaultConfig = true
93-
config = files("${project.rootDir}/configuration/detekt/detekt-configuration.yml")
94-
}
9586
}
9687

9788
tasks.withType<Test> {

configuration/detekt/detekt-configuration.yml

Lines changed: 0 additions & 7 deletions
This file was deleted.

configuration/spotbugs/bugsExcludeFilter.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@
1010
</Match>
1111
<Match>
1212
<Source name="~.*generated-sources.*" />
13+
<Source name="~.*generated-test-sources.*" />
1314
</Match>
1415
</FindBugsFilter>

core/src/main/java/com/jashmore/sqs/retriever/batching/BatchingMessageRetriever.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import software.amazon.awssdk.core.exception.SdkInterruptedException;
2424
import software.amazon.awssdk.services.sqs.SqsAsyncClient;
2525
import software.amazon.awssdk.services.sqs.model.Message;
26+
import software.amazon.awssdk.services.sqs.model.MessageSystemAttributeName;
2627
import software.amazon.awssdk.services.sqs.model.QueueAttributeName;
2728
import software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest;
2829
import software.amazon.awssdk.services.sqs.model.ReceiveMessageResponse;
@@ -187,7 +188,7 @@ private ReceiveMessageRequest buildReceiveMessageRequest(final int numberOfMessa
187188
final ReceiveMessageRequest.Builder requestBuilder = ReceiveMessageRequest
188189
.builder()
189190
.queueUrl(queueProperties.getQueueUrl())
190-
.attributeNames(QueueAttributeName.ALL)
191+
.messageSystemAttributeNames(MessageSystemAttributeName.ALL)
191192
.messageAttributeNames(QueueAttributeName.ALL.toString())
192193
.maxNumberOfMessages(numberOfMessagesToObtain)
193194
.waitTimeSeconds(MAX_SQS_RECEIVE_WAIT_TIME_IN_SECONDS);

core/src/main/java/com/jashmore/sqs/retriever/prefetch/PrefetchingMessageRetriever.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import software.amazon.awssdk.core.exception.SdkInterruptedException;
2121
import software.amazon.awssdk.services.sqs.SqsAsyncClient;
2222
import software.amazon.awssdk.services.sqs.model.Message;
23+
import software.amazon.awssdk.services.sqs.model.MessageSystemAttributeName;
2324
import software.amazon.awssdk.services.sqs.model.QueueAttributeName;
2425
import software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest;
2526
import software.amazon.awssdk.services.sqs.model.ReceiveMessageResponse;
@@ -166,7 +167,7 @@ private ReceiveMessageRequest buildReceiveMessageRequest() {
166167
final ReceiveMessageRequest.Builder requestBuilder = ReceiveMessageRequest
167168
.builder()
168169
.queueUrl(queueProperties.getQueueUrl())
169-
.attributeNames(QueueAttributeName.ALL)
170+
.messageSystemAttributeNames(MessageSystemAttributeName.ALL)
170171
.messageAttributeNames(QueueAttributeName.ALL.toString())
171172
.waitTimeSeconds(MAX_SQS_RECEIVE_WAIT_TIME_IN_SECONDS)
172173
.maxNumberOfMessages(numberOfMessagesToObtain);

core/src/test/java/com/jashmore/sqs/retriever/batching/BatchingMessageRetrieverTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.mockito.junit.jupiter.MockitoExtension;
2828
import software.amazon.awssdk.services.sqs.SqsAsyncClient;
2929
import software.amazon.awssdk.services.sqs.model.Message;
30-
import software.amazon.awssdk.services.sqs.model.QueueAttributeName;
30+
import software.amazon.awssdk.services.sqs.model.MessageSystemAttributeName;
3131
import software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest;
3232
import software.amazon.awssdk.services.sqs.model.ReceiveMessageResponse;
3333

@@ -453,8 +453,8 @@ void allMessageAttributesShouldBeDownloadedWhenRequestingMessages() {
453453
ReceiveMessageRequest.class
454454
);
455455
verify(sqsAsyncClient).receiveMessage(receiveMessageRequestArgumentCaptor.capture());
456-
assertThat(receiveMessageRequestArgumentCaptor.getValue().messageAttributeNames())
457-
.containsExactly(QueueAttributeName.ALL.toString());
456+
assertThat(receiveMessageRequestArgumentCaptor.getValue().messageSystemAttributeNames())
457+
.containsExactly(MessageSystemAttributeName.ALL);
458458
}
459459

460460
@Test
@@ -483,7 +483,8 @@ void allMessageSystemAttributesShouldBeDownloadedWhenRequestingMessages() {
483483
ReceiveMessageRequest.class
484484
);
485485
verify(sqsAsyncClient).receiveMessage(receiveMessageRequestArgumentCaptor.capture());
486-
assertThat(receiveMessageRequestArgumentCaptor.getValue().attributeNames()).containsExactly(QueueAttributeName.ALL);
486+
assertThat(receiveMessageRequestArgumentCaptor.getValue().messageSystemAttributeNames())
487+
.containsExactly(MessageSystemAttributeName.ALL);
487488
}
488489

489490
@Test

core/src/test/java/com/jashmore/sqs/retriever/prefetch/PrefetchingMessageRetrieverTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import software.amazon.awssdk.core.exception.SdkInterruptedException;
3838
import software.amazon.awssdk.services.sqs.SqsAsyncClient;
3939
import software.amazon.awssdk.services.sqs.model.Message;
40+
import software.amazon.awssdk.services.sqs.model.MessageSystemAttributeName;
4041
import software.amazon.awssdk.services.sqs.model.QueueAttributeName;
4142
import software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest;
4243
import software.amazon.awssdk.services.sqs.model.ReceiveMessageResponse;
@@ -406,8 +407,7 @@ void allMessageAttributesAreIncludedInMessagesWhenRetrieved() {
406407
ReceiveMessageRequest.class
407408
);
408409
verify(sqsAsyncClient).receiveMessage(receiveMessageRequestArgumentCaptor.capture());
409-
assertThat(receiveMessageRequestArgumentCaptor.getValue().messageAttributeNames())
410-
.containsExactly(QueueAttributeName.ALL.toString());
410+
assertThat(receiveMessageRequestArgumentCaptor.getValue().messageAttributeNames()).contains(QueueAttributeName.ALL.toString());
411411
}
412412

413413
@Test
@@ -428,7 +428,7 @@ void allMessageSystemAttributesAreIncludedInMessagesWhenRetrieved() {
428428
ReceiveMessageRequest.class
429429
);
430430
verify(sqsAsyncClient).receiveMessage(receiveMessageRequestArgumentCaptor.capture());
431-
assertThat(receiveMessageRequestArgumentCaptor.getValue().attributeNames()).contains(QueueAttributeName.ALL);
431+
assertThat(receiveMessageRequestArgumentCaptor.getValue().messageSystemAttributeNames()).contains(MessageSystemAttributeName.ALL);
432432
}
433433

434434
@Test

doc/how-to-guides/spring/spring-how-to-version-payload-schemas-using-spring-cloud-schema-registry.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Spring - How to version message payload Schemas using Spring Cloud Schema Registry
22

33
As your application grows over time the format of the data that needs to be sent in the SQS messages may change as well. To allow for
4-
these changes, the [Spring Cloud Schema Registry](https://cloud.spring.io/spring-cloud-static/spring-cloud-schema-registry/1.0.0.RC1/reference/html/spring-cloud-schema-registry.html)
4+
these changes, the [Spring Cloud Schema Registry](https://docs.spring.io/spring-cloud-schema-registry/docs/current/reference/html/spring-cloud-schema-registry.html)
55
can be used to track the version of your schemas, allowing the SQS consumer to be able to interpret multiple versions of your payload.
66

77
## Full reference

examples/core-kotlin-example/src/main/kotlin/com/jashmore/sqs/examples/KotlinConcurrentBrokerExample.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ private val log: Logger = LoggerFactory.getLogger("example")
2929
private val CONCURRENCY_LEVEL_PERIOD = Duration.ofSeconds(5)
3030
private const val CONCURRENCY_LIMIT = 10
3131

32-
private val objectMapper = ObjectMapper().registerModule(KotlinModule())
32+
private val objectMapper = ObjectMapper().registerModule(KotlinModule.Builder().build())
3333

3434
/**
3535
* This example shows the core framework being used to processing messages place onto the queue with a dynamic level of concurrency via the

examples/spring-cloud-schema-registry-example/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
This example shows how you can consume messages which have been defined using an [Avro](https://avro.apache.org/docs/1.9.2/gettingstartedjava.html)
44
Schema and
5-
the [Spring Cloud Schema Registry](https://cloud.spring.io/spring-cloud-static/spring-cloud-schema-registry/1.0.0.RC1/reference/html/spring-cloud-schema-registry.html).
5+
the [Spring Cloud Schema Registry](https://docs.spring.io/spring-cloud-schema-registry/docs/current/reference/html/spring-cloud-schema-registry.html).
66

77
To find the corresponding code look in the [Spring Cloud Schema Registry Extension](../../extensions/spring-cloud-schema-registry-extension) module.
88

0 commit comments

Comments
 (0)