Skip to content

Commit 2696ea5

Browse files
rakduttakevalmahajan
authored andcommitted
enabled
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
1 parent 5fb306a commit 2696ea5

File tree

5 files changed

+91
-75
lines changed

5 files changed

+91
-75
lines changed

mcpgateway/admin.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -854,7 +854,7 @@ async def admin_list_servers(
854854
... icon="test-icon.png",
855855
... created_at=datetime.now(timezone.utc),
856856
... updated_at=datetime.now(timezone.utc),
857-
... is_active=True,
857+
... enabled=True,
858858
... associated_tools=["tool1", "tool2"],
859859
... associated_resources=[1, 2],
860860
... associated_prompts=[1],
@@ -960,7 +960,7 @@ async def admin_get_server(server_id: str, db: Session = Depends(get_db), user=D
960960
... icon="test-icon.png",
961961
... created_at=datetime.now(timezone.utc),
962962
... updated_at=datetime.now(timezone.utc),
963-
... is_active=True,
963+
... enabled=True,
964964
... associated_tools=["tool1"],
965965
... associated_resources=[1],
966966
... associated_prompts=[1],
@@ -1012,7 +1012,7 @@ async def admin_get_server(server_id: str, db: Session = Depends(get_db), user=D
10121012
except ServerNotFoundError as e:
10131013
raise HTTPException(status_code=404, detail=str(e))
10141014
except Exception as e:
1015-
LOGGER.error(f"Error getting gateway {server_id}: {e}")
1015+
LOGGER.error(f"Error getting server {server_id}: {e}")
10161016
raise e
10171017

10181018

@@ -1721,7 +1721,7 @@ async def admin_list_resources(
17211721
... size=100,
17221722
... created_at=datetime.now(timezone.utc),
17231723
... updated_at=datetime.now(timezone.utc),
1724-
... is_active=True,
1724+
... enabled=True,
17251725
... metrics=ResourceMetrics(
17261726
... total_executions=5, successful_executions=5, failed_executions=0,
17271727
... failure_rate=0.0, min_response_time=0.1, max_response_time=0.5,
@@ -1747,7 +1747,7 @@ async def admin_list_resources(
17471747
... id="39334ce0ed2644d79ede8913a66930c9", uri="test://resource/2", name="Inactive Resource",
17481748
... description="Another test", mime_type="application/json", size=50,
17491749
... created_at=datetime.now(timezone.utc), updated_at=datetime.now(timezone.utc),
1750-
... is_active=False, metrics=ResourceMetrics(
1750+
... enabled=False, metrics=ResourceMetrics(
17511751
... total_executions=0, successful_executions=0, failed_executions=0,
17521752
... failure_rate=0.0, min_response_time=0.0, max_response_time=0.0,
17531753
... avg_response_time=0.0, last_execution_time=None),
@@ -2235,7 +2235,7 @@ async def admin_ui(
22352235
True
22362236
>>>
22372237
>>> # Test with populated data (mocking a few items)
2238-
>>> mock_server = ServerRead(id="s1", name="S1", description="d", created_at=datetime.now(timezone.utc), updated_at=datetime.now(timezone.utc), is_active=True, associated_tools=[], associated_resources=[], associated_prompts=[], icon="i", metrics=ServerMetrics(total_executions=0, successful_executions=0, failed_executions=0, failure_rate=0.0, min_response_time=0.0, max_response_time=0.0, avg_response_time=0.0, last_execution_time=None))
2238+
>>> mock_server = ServerRead(id="s1", name="S1", description="d", created_at=datetime.now(timezone.utc), updated_at=datetime.now(timezone.utc), enabled=True, associated_tools=[], associated_resources=[], associated_prompts=[], icon="i", metrics=ServerMetrics(total_executions=0, successful_executions=0, failed_executions=0, failure_rate=0.0, min_response_time=0.0, max_response_time=0.0, avg_response_time=0.0, last_execution_time=None))
22392239
>>> mock_tool = ToolRead(
22402240
... id="t1", name="T1", original_name="T1", url="http://t1.com", description="d",
22412241
... created_at=datetime.now(timezone.utc), updated_at=datetime.now(timezone.utc),
@@ -6117,7 +6117,7 @@ async def admin_resources_partial_html(
61176117

61186118
# Apply active/inactive filter
61196119
if not include_inactive:
6120-
query = query.where(DbResource.is_active.is_(True))
6120+
query = query.where(DbResource.enabled.is_(True))
61216121

61226122
# Access conditions: owner, team, public
61236123
access_conditions = [DbResource.owner_email == user_email]
@@ -6141,7 +6141,7 @@ async def admin_resources_partial_html(
61416141
else:
61426142
count_query = count_query.where(DbResource.gateway_id.in_(non_null_ids))
61436143
if not include_inactive:
6144-
count_query = count_query.where(DbResource.is_active.is_(True))
6144+
count_query = count_query.where(DbResource.enabled.is_(True))
61456145

61466146
total_items = db.scalar(count_query) or 0
61476147

@@ -6326,7 +6326,7 @@ async def admin_get_all_resource_ids(
63266326
LOGGER.debug(f"Filtering resources by gateway IDs: {non_null_ids}")
63276327

63286328
if not include_inactive:
6329-
query = query.where(DbResource.is_active.is_(True))
6329+
query = query.where(DbResource.enabled.is_(True))
63306330

63316331
access_conditions = [DbResource.owner_email == user_email, DbResource.visibility == "public"]
63326332
if team_ids:
@@ -6374,7 +6374,7 @@ async def admin_search_resources(
63746374

63756375
query = select(DbResource.id, DbResource.name, DbResource.description)
63766376
if not include_inactive:
6377-
query = query.where(DbResource.is_active.is_(True))
6377+
query = query.where(DbResource.enabled.is_(True))
63786378

63796379
access_conditions = [DbResource.owner_email == user_email, DbResource.visibility == "public"]
63806380
if team_ids:
@@ -8115,7 +8115,7 @@ async def admin_get_resource(resource_id: str, db: Session = Depends(get_db), us
81158115
>>> mock_resource = ResourceRead(
81168116
... id=resource_id, uri=resource_uri, name="Get Resource", description="Test",
81178117
... mime_type="text/plain", size=10, created_at=datetime.now(timezone.utc),
8118-
... updated_at=datetime.now(timezone.utc), is_active=True, metrics=ResourceMetrics(
8118+
... updated_at=datetime.now(timezone.utc), enabled=True, metrics=ResourceMetrics(
81198119
... total_executions=0, successful_executions=0, failed_executions=0,
81208120
... failure_rate=0.0, min_response_time=0.0, max_response_time=0.0, avg_response_time=0.0,
81218121
... last_execution_time=None
@@ -12297,7 +12297,7 @@ async def get_servers_section(
1229712297
"name": server.name,
1229812298
"description": server.description,
1229912299
"tags": server.tags or [],
12300-
"isActive": server.is_active,
12300+
"isActive": server.enabled,
1230112301
"team_id": getattr(server, "team_id", None),
1230212302
"visibility": getattr(server, "visibility", "private"),
1230312303
}

mcpgateway/alembic/versions/356a2d4eed6f_uuid_change_for_prompt_and_resources.py

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def upgrade() -> None:
4444
sa.Column("argument_schema", sa.JSON, nullable=True),
4545
sa.Column("created_at", sa.DateTime(timezone=True), nullable=True),
4646
sa.Column("updated_at", sa.DateTime(timezone=True), nullable=True),
47-
sa.Column("is_active", sa.Boolean, nullable=True),
47+
sa.Column("enabled", sa.Boolean, nullable=True),
4848
sa.Column("tags", sa.JSON, nullable=False),
4949
sa.Column("created_by", sa.String(255), nullable=True),
5050
sa.Column("created_from_ip", sa.String(45), nullable=True),
@@ -67,7 +67,7 @@ def upgrade() -> None:
6767

6868
# 3) Copy data from prompts into prompts_tmp using id_new as id
6969
copy_cols = (
70-
"id, name, description, template, argument_schema, created_at, updated_at, is_active, tags,"
70+
"id, name, description, template, argument_schema, created_at, updated_at, enabled, tags,"
7171
" created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip,"
7272
" modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility"
7373
)
@@ -151,7 +151,7 @@ def upgrade() -> None:
151151
sa.Column("uri_template", sa.Text, nullable=True),
152152
sa.Column("created_at", sa.DateTime(timezone=True), nullable=True),
153153
sa.Column("updated_at", sa.DateTime(timezone=True), nullable=True),
154-
sa.Column("is_active", sa.Boolean, nullable=True),
154+
sa.Column("enabled", sa.Boolean, nullable=True),
155155
sa.Column("tags", sa.JSON, nullable=False),
156156
sa.Column("text_content", sa.Text, nullable=True),
157157
sa.Column("binary_content", sa.LargeBinary, nullable=True),
@@ -175,7 +175,7 @@ def upgrade() -> None:
175175
)
176176

177177
# Copy data into resources_tmp using id_new
178-
res_copy_cols = "id, uri, name, description, mime_type, size, uri_template, created_at, updated_at, is_active, tags, text_content, binary_content, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility"
178+
res_copy_cols = "id, uri, name, description, mime_type, size, uri_template, created_at, updated_at, enabled, tags, text_content, binary_content, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility"
179179
conn.execute(
180180
text(
181181
(
@@ -255,6 +255,14 @@ def upgrade() -> None:
255255
op.rename_table("server_resource_association_tmp", "server_resource_association")
256256
op.rename_table("resource_subscriptions_tmp", "resource_subscriptions")
257257

258+
with op.batch_alter_table("servers") as batch_op:
259+
batch_op.alter_column(
260+
"is_active",
261+
new_column_name="enabled",
262+
existing_type=sa.Boolean(),
263+
existing_server_default=sa.text("1"),
264+
existing_nullable=False,
265+
)
258266

259267
def downgrade() -> None:
260268
"""Downgrade schema."""
@@ -296,7 +304,7 @@ def downgrade() -> None:
296304
# We'll preserve uniqueness by using the team_id/owner_email/name triple to later remap.
297305
conn.execute(
298306
text(
299-
"INSERT INTO prompts_old (name, description, template, argument_schema, created_at, updated_at, is_active, tags, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility) SELECT name, description, template, argument_schema, created_at, updated_at, is_active, tags, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility FROM prompts"
307+
"INSERT INTO prompts_old (name, description, template, argument_schema, created_at, updated_at, is_active, tags, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility) SELECT name, description, template, argument_schema, created_at, updated_at, enabled, tags, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility FROM prompts"
300308
)
301309
)
302310

@@ -418,7 +426,7 @@ def downgrade() -> None:
418426
# 2) Insert rows from current resources into resources_old letting id autoincrement.
419427
conn.execute(
420428
text(
421-
"INSERT INTO resources_old (uri, name, description, mime_type, size, uri_template, created_at, updated_at, is_active, tags, text_content, binary_content, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility) SELECT uri, name, description, mime_type, size, uri_template, created_at, updated_at, is_active, tags, text_content, binary_content, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility FROM resources"
429+
"INSERT INTO resources_old (uri, name, description, mime_type, size, uri_template, created_at, updated_at, is_active, tags, text_content, binary_content, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility) SELECT uri, name, description, mime_type, size, uri_template, created_at, updated_at, enabled, tags, text_content, binary_content, created_by, created_from_ip, created_via, created_user_agent, modified_by, modified_from_ip, modified_via, modified_user_agent, import_batch_id, federation_source, version, gateway_id, team_id, owner_email, visibility FROM resources"
422430
)
423431
)
424432

@@ -519,3 +527,11 @@ def downgrade() -> None:
519527
op.rename_table("resource_metrics_old", "resource_metrics")
520528
op.rename_table("server_resource_association_old", "server_resource_association")
521529
op.rename_table("resource_subscriptions_old", "resource_subscriptions")
530+
with op.batch_alter_table("servers") as batch_op:
531+
batch_op.alter_column(
532+
"enabled",
533+
new_column_name="is_active",
534+
existing_type=sa.Boolean(),
535+
existing_server_default=sa.text("1"),
536+
existing_nullable=False,
537+
)

mcpgateway/services/completion_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ async def _complete_resource_uri(self, db: Session, ref: Dict[str, Any], arg_val
266266
raise CompletionError("Missing URI template")
267267

268268
# List matching resources
269-
resources = db.execute(select(DbResource).where(DbResource.is_active)).scalars().all()
269+
resources = db.execute(select(DbResource).where(DbResource.enabled)).scalars().all()
270270

271271
# Filter by URI pattern
272272
matches = []

0 commit comments

Comments
 (0)