Modbus analyze_protocol not reachable #118
Description
After trying several times/different ways to create a Modbus dump to help with adding support for EG4's Gridboss (#103), I did a deeper dive into how/when the analyze_protocol function was being called. It appears that the call to run it was moved and then accidentally removed as part of a roll back and therefore the analyze_protocol = True config option doesn't do anything.
- Commit c0510f6 moved the
self.analyze_protocol()call from classes/transports/modbus_base.py to classes/transports/modbus_rtu.py - Commit 2ce4143 then rolled back several other changes including the addition of the
self.analyze_protocol()call to classes/transports/modbus_rtu.py - It appears that commit 1abcce6 was meant to undo some of the changes to classes/transports/modbus_base.py but the call of
self.analyze_protocol()wasn't re-added. - Looking through the remaining commits and the code as it currently sits, I can't see where it would have been added back in as an option to call.
I'm not fully sure where self.analyze_protocol() needs to be re-added (base vs rtu) but I am going poke at it a bit and see if I can't figure it out.