Merge pull request #1894 from Haehnchen/feature/1893-attributes-workaround

#1893 workaround in wrongly implemented attributes handling; catch er…

Author: Haehnchen

src/main/java/fr/adrienbrault/idea/symfony2plugin/util/PhpPsiAttributesUtil.java

@@ -63,10 +63,22 @@ public static String getAttributeValueByNameAsStringWithDefaultParameterFallback
         for (PhpAttribute.PhpAttributeArgument argument : attribute.getArguments()) {
             PhpExpectedFunctionArgument argument1 = argument.getArgument();
             if (argument1.getArgumentIndex() == 0) {
+                // what a mess here :)
+                // createReference is stopping with exception on array values
+                String value = argument1.getValue();
+                String s = org.apache.commons.lang3.StringUtils.normalizeSpace(value).replaceAll("[\\n\\t ]", "");
+                if (s.startsWith("['") || s.startsWith("[\"")) {
+                    continue;
+                }
 
                 // hint: reference is a complete fake object lazily created; it is not reflect the real element :(
                 // PhpPsiElementFactory.createPhpPsiFromText => com.jetbrains.php.lang.psi.stubs.indexes.expectedArguments.PhpExpectedFunctionClassConstantArgument.createReference
-                @NotNull PsiElement namedElement = argument1.createReference(attribute.getProject());
+                @NotNull PsiElement namedElement;
+                try {
+                    namedElement = argument1.createReference(attribute.getProject());
+                } catch (AssertionError e) {
+                    continue;
+                }
 
                 if (namedElement instanceof StringLiteralExpression) {
                     // we can trust the string representation here, looks to be right implemented

src/test/java/fr/adrienbrault/idea/symfony2plugin/tests/stubs/indexes/fixtures/RoutesStubIndex.php

@@ -204,6 +204,14 @@ public function attributesPathFoo1()
         public function attributesPathFoo2()
         {
         }
+
+        #[Route([
+            'cs' => '/foobar/baz/{id}',
+            'sk' => '/foobarbaz/bat/{id}',
+        ], name: 'dashboard', methods: ['GET'])]
+        public function nameAsArray()
+        {
+        }
     }
 }