deduped tech requests

Author: max-ostapenko

src/controllers/cwvtechController.js

@@ -1,65 +1,98 @@
 import { firestoreOld } from '../utils/db.js';
 const firestore = firestoreOld;
 
-import { createSuccessResponse } from '../utils/helpers.js';
 import {
-  REQUIRED_PARAMS,
-  validateRequiredParams,
-  sendValidationError,
-  applyDateFilters,
-  applyStandardFilters,
-  preprocessParams,
-  handleControllerError
+  getLatestDate
 } from '../utils/controllerHelpers.js';
 
 const TABLE = 'core_web_vitals';
 
 /**
- * List Core Web Vitals data with filtering
+ * List Core Web Vitals data with filtering - Optimized version
  */
 const listCWVTechData = async (req, res) => {
   try {
     const params = req.query;
 
-    // Validate required parameters
-    const requiredParams = [
-      REQUIRED_PARAMS.GEO,
-      REQUIRED_PARAMS.RANK,
-      REQUIRED_PARAMS.TECHNOLOGY
-    ];
-
-    const validationErrors = validateRequiredParams(params, requiredParams);
-    if (validationErrors) {
-      sendValidationError(res, validationErrors);
+    // Validate required parameters inline for speed
+    if (!params.geo || !params.rank || !params.technology) {
+      res.statusCode = 400;
+      res.end(JSON.stringify({
+        success: false,
+        errors: [
+          ...(!params.geo ? [{ geo: 'missing geo parameter' }] : []),
+          ...(!params.rank ? [{ rank: 'missing rank parameter' }] : []),
+          ...(!params.technology ? [{ technology: 'missing technology parameter' }] : [])
+        ]
+      }));
       return;
     }
 
-    // Preprocess parameters and get technology array
-    const { params: processedParams, techArray } = await preprocessParams(firestore, params, TABLE);
-    const data = [];
+    // Fast preprocessing - handle 'latest' date and technology array
+    const techArray = params.technology ? decodeURIComponent(params.technology).split(',') : [];
+
+    // Handle 'latest' date with caching
+    let startDate = params.start;
+    if (startDate === 'latest') {
+      startDate = await getLatestDate(firestore, TABLE);
+    }
+
+    // Build optimized query
+    let query = firestore.collection(TABLE);
 
-    // Query for each technology
-    for (const technology of techArray) {
-      let query = firestore.collection(TABLE);
+    // Apply required filters
+    query = query.where('geo', '==', params.geo);
+    query = query.where('rank', '==', params.rank);
 
-      // Apply standard filters including version filter
-      query = applyStandardFilters(query, processedParams, technology, techArray);
+    // Apply technology filter efficiently
+    if (techArray.length <= 30) {
+      // Use 'in' operator for batch processing (Firestore limit: 30 values)
+      query = query.where('technology', 'in', techArray);
+    } else {
+      // Parallel queries for >10 technologies (rare case)
+      const queryPromises = techArray.map(async (technology) => {
+        let individualQuery = firestore.collection(TABLE)
+          .where('geo', '==', params.geo)
+          .where('rank', '==', params.rank)
+          .where('technology', '==', technology);
 
-      // Apply date filters
-      query = applyDateFilters(query, processedParams);
+        if (startDate) individualQuery = individualQuery.where('date', '>=', startDate);
+        if (params.end) individualQuery = individualQuery.where('date', '<=', params.end);
 
-      // Execute query
-      const snapshot = await query.get();
-      snapshot.forEach(doc => {
-        data.push(doc.data());
+        const snapshot = await individualQuery.get();
+        const results = [];
+        snapshot.forEach(doc => results.push(doc.data()));
+        return results;
       });
+
+      const results = await Promise.all(queryPromises);
+      const data = results.flat();
+
+      res.statusCode = 200;
+      res.end(JSON.stringify(data));
+      return;
     }
 
-    // Send response
+    // Apply date filters
+    if (startDate) query = query.where('date', '>=', startDate);
+    if (params.end) query = query.where('date', '<=', params.end);
+
+    // Execute single optimized query
+    const snapshot = await query.get();
+    const data = [];
+    snapshot.forEach(doc => {
+      data.push(doc.data());
+    });
+
+    // Direct response without wrapper functions
     res.statusCode = 200;
-    res.end(JSON.stringify(createSuccessResponse(data)));
+    res.end(JSON.stringify(data));
   } catch (error) {
-    handleControllerError(res, error, 'fetching Core Web Vitals data');
+    console.error('Error fetching Core Web Vitals data:', error);
+    res.statusCode = 500;
+    res.end(JSON.stringify({
+      errors: [{ error: 'Failed to fetch Core Web Vitals data' }]
+    }));
   }
 };