From e6654b76169e8a3b57433fc28eecac3c80e62a7a Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:27:07 -0600 Subject: [PATCH 01/16] addresses windows CI failures --- config/cmake/binex/example/CMakeLists.txt | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/config/cmake/binex/example/CMakeLists.txt b/config/cmake/binex/example/CMakeLists.txt index 35e7c429..c0fe3353 100644 --- a/config/cmake/binex/example/CMakeLists.txt +++ b/config/cmake/binex/example/CMakeLists.txt @@ -102,6 +102,8 @@ if (H5PL_BUILD_TESTING) -D "TEST_ERRREF=1" -D "GREP_ERRREF=Filter present but encoding disabled" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" + -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" + -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname}-ERR PROPERTIES DEPENDS ${testname}-clearall) @@ -123,6 +125,8 @@ if (H5PL_BUILD_TESTING) -D "TEST_OUTPUT=${testname}.out" -D "TEST_REFERENCE=${testname}.tst" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" + -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" + -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname} PROPERTIES DEPENDS ${testname}-clearall) @@ -142,6 +146,8 @@ if (H5PL_BUILD_TESTING) -D "TEST_EXPECT=0" -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" + -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" + -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) else () @@ -158,6 +164,8 @@ if (H5PL_BUILD_TESTING) -D "TEST_EXPECT=0" -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" + -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" + -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) else () @@ -174,6 +182,8 @@ if (H5PL_BUILD_TESTING) -D "TEST_MASK_MOD=1" -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" + -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" + -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) endif () From 51dfd49e39998d35325e60235081291d0cb42790 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:33:59 -0600 Subject: [PATCH 02/16] add DT badge --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index aaf23dbb..57fd153d 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ # Select HDF5 Filter Plugins Repository +[![Daily Build](https://github.com/HDFGroup/hdf5_plugins/actions/workflows/daily-build.yml/badge.svg)](https://github.com/HDFGroup/hdf5_plugins/actions/workflows/daily-build.yml) + This repository contains a select number of registered HDF5® filter plugins for use in HDF Group's development and testing activities of the HDF5® library. The HDF Group is the developer, maintainer, and steward of the HDF5® software. Find more information about The HDF Group, the HDF5® Community, and other HDF5® software projects, tools, and services at [The HDF Group's website](https://www.hdfgroup.org/). From 7ed7a6947c4c3918bebbd206bca04b6fb284ff49 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:43:27 -0600 Subject: [PATCH 03/16] set default for use_ignore to 'check' --- .github/workflows/daily-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily-build.yml b/.github/workflows/daily-build.yml index 24264137..3efd1a1c 100644 --- a/.github/workflows/daily-build.yml +++ b/.github/workflows/daily-build.yml @@ -55,7 +55,7 @@ jobs: - name: Read inputs id: getinputs run: | - echo "INPUTS_IGNORE=${{ inputs.use_ignore }}" >> $GITHUB_OUTPUT + echo "INPUTS_IGNORE=${{ inputs.use_ignore || 'check' }}" >> $GITHUB_OUTPUT - run: echo "use_ignore is ${{ steps.getinputs.outputs.INPUTS_IGNORE }}." From 140d2b56a07aa52b50695217ae28ee0b0bd9df29 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:46:56 -0600 Subject: [PATCH 04/16] fixed case mis-match --- .github/workflows/tarball.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index 7e2be850..7b04ba61 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -73,7 +73,7 @@ jobs: uses: adriangl/check-new-commits-action@v1 with: seconds: 86400 # One day in seconds - branch: '${{ steps.get-branch-name.outputs.branch_ref }}' + branch: '${{ steps.get-branch-name.outputs.BRANCH_REF }}' if: ${{ (inputs.use_environ == 'snapshots' && inputs.use_ignore == 'check') }} - run: echo "You have ${{ steps.check-new-commits.outputs.new-commits-number }} new commit(s) in ${{ steps.get-branch-name.outputs.BRANCH_REF }} ✅!" From 87c9428447b0c1958ae012ae403482d30f5b79f3 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:49:01 -0600 Subject: [PATCH 05/16] debug --- .github/workflows/tarball.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index 7b04ba61..e18f5330 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -68,12 +68,19 @@ jobs: SHORT_SHA=$(echo "${{ env.GITHUB_WF_SHA }}" | cut -c1-7) echo "BRANCH_SHA=$SHORT_SHA" >> $GITHUB_OUTPUT + - name: Debug branch info + run: | + echo "Branch ref: ${{ steps.get-branch-name.outputs.BRANCH_REF }}" + echo "Repository: ${{ github.repository }}" + echo "Event name: ${{ github.event_name }}" + - name: Check for changed source id: check-new-commits uses: adriangl/check-new-commits-action@v1 with: seconds: 86400 # One day in seconds branch: '${{ steps.get-branch-name.outputs.BRANCH_REF }}' + repo-token: ${{ secrets.GITHUB_TOKEN }} if: ${{ (inputs.use_environ == 'snapshots' && inputs.use_ignore == 'check') }} - run: echo "You have ${{ steps.check-new-commits.outputs.new-commits-number }} new commit(s) in ${{ steps.get-branch-name.outputs.BRANCH_REF }} ✅!" From 577df2c346b7a2308ea7ccfc57a266363fca7988 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:51:11 -0600 Subject: [PATCH 06/16] debug --- .github/workflows/tarball.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index e18f5330..07942485 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -80,7 +80,7 @@ jobs: with: seconds: 86400 # One day in seconds branch: '${{ steps.get-branch-name.outputs.BRANCH_REF }}' - repo-token: ${{ secrets.GITHUB_TOKEN }} + token: ${{ secrets.GITHUB_TOKEN }} if: ${{ (inputs.use_environ == 'snapshots' && inputs.use_ignore == 'check') }} - run: echo "You have ${{ steps.check-new-commits.outputs.new-commits-number }} new commit(s) in ${{ steps.get-branch-name.outputs.BRANCH_REF }} ✅!" From 7dc53e728d9dfb9760e8c9244ef437e0ede7140a Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:53:43 -0600 Subject: [PATCH 07/16] debug --- .github/workflows/tarball.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index 07942485..df5a6c1e 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -44,7 +44,7 @@ jobs: name: Check for recent commits runs-on: ubuntu-latest outputs: - has_changes: ${{ steps.check-new-commits.outputs.has-new-commits }} + has_changes: ${{ steps.check-new-commits.outputs.has-new-commits || steps.set-pr-commits.outputs.has-new-commits }} branch_ref: ${{ steps.get-branch-name.outputs.BRANCH_REF }} branch_sha: ${{ steps.get-branch-sha.outputs.BRANCH_SHA }} steps: @@ -81,7 +81,12 @@ jobs: seconds: 86400 # One day in seconds branch: '${{ steps.get-branch-name.outputs.BRANCH_REF }}' token: ${{ secrets.GITHUB_TOKEN }} - if: ${{ (inputs.use_environ == 'snapshots' && inputs.use_ignore == 'check') }} + if: ${{ (inputs.use_environ == 'snapshots' && inputs.use_ignore == 'check' && github.event_name != 'pull_request') }} + + - name: Set has-new-commits for pull requests + id: set-pr-commits + run: echo "has-new-commits=true" >> $GITHUB_OUTPUT + if: ${{ github.event_name == 'pull_request' }} - run: echo "You have ${{ steps.check-new-commits.outputs.new-commits-number }} new commit(s) in ${{ steps.get-branch-name.outputs.BRANCH_REF }} ✅!" if: ${{ steps.check-new-commits.outputs.has-new-commits == 'true' }} From 935537a56c66b019f6ba4b5284b65f8c96142884 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 16:55:33 -0600 Subject: [PATCH 08/16] debug1 --- .github/workflows/tarball.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index df5a6c1e..6ccf47ba 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -107,7 +107,7 @@ jobs: uses: actions/checkout@v4.1.7 with: path: hdfsrc - ref: '${{needs.check_commits.outputs.branch_ref }}' + ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || needs.check_commits.outputs.branch_ref }} - name: Retrieve version id: version From 603eb6227317998eb9c6094578a3cc57889bb852 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 17:01:36 -0600 Subject: [PATCH 09/16] skip releasee workflows for PRs --- .github/workflows/daily-build.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/daily-build.yml b/.github/workflows/daily-build.yml index 3efd1a1c..f8e86dec 100644 --- a/.github/workflows/daily-build.yml +++ b/.github/workflows/daily-build.yml @@ -108,6 +108,7 @@ jobs: use_hdf: ${{ needs.get-old-names.outputs.hdf5-name }} file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} use_environ: snapshots + if: ${{ github.event_name != 'pull_request' }} call-workflow-release: needs: [get-old-names, call-workflow-tarball, call-workflow-ctest] @@ -120,7 +121,7 @@ jobs: file_sha: ${{ needs.call-workflow-tarball.outputs.file_sha }} use_tag: snapshot use_environ: snapshots - if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} + if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} call-workflow-remove: needs: [get-old-names, call-workflow-tarball, call-workflow-ctest, call-workflow-release] @@ -131,7 +132,7 @@ jobs: file_base: ${{ needs.get-old-names.outputs.plugin-name }} use_tag: snapshot use_environ: snapshots - if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) && (needs.get-old-names.outputs.hdf5-name != needs.call-workflow-tarball.outputs.file_base) }} + if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) && (needs.get-old-names.outputs.hdf5-name != needs.call-workflow-tarball.outputs.file_base) }} call-workflow-versions: uses: ./.github/workflows/check-releases.yml From e530dd4a9502ffa16a4a3aad3f5122402b954c11 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 17:02:57 -0600 Subject: [PATCH 10/16] removed debug output --- .github/workflows/tarball.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index 6ccf47ba..0b9150e6 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -68,12 +68,6 @@ jobs: SHORT_SHA=$(echo "${{ env.GITHUB_WF_SHA }}" | cut -c1-7) echo "BRANCH_SHA=$SHORT_SHA" >> $GITHUB_OUTPUT - - name: Debug branch info - run: | - echo "Branch ref: ${{ steps.get-branch-name.outputs.BRANCH_REF }}" - echo "Repository: ${{ github.repository }}" - echo "Event name: ${{ github.event_name }}" - - name: Check for changed source id: check-new-commits uses: adriangl/check-new-commits-action@v1 From 2b16aaae85ffdc75f9f02e903325556535aafb76 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 17:07:44 -0600 Subject: [PATCH 11/16] skip testing releasd tarballs, and no articts for PRs --- .github/workflows/daily-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/daily-build.yml b/.github/workflows/daily-build.yml index f8e86dec..60b697b2 100644 --- a/.github/workflows/daily-build.yml +++ b/.github/workflows/daily-build.yml @@ -75,7 +75,7 @@ jobs: file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} use_hdf: ${{ needs.get-old-names.outputs.hdf5-name }} use_environ: snapshots - if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} + if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} call-workflow-ctest: needs: [get-old-names, call-workflow-tarball] From 166327f6ee6b13081c3af1d1751b57cdf8be9970 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 17:19:03 -0600 Subject: [PATCH 12/16] test --- .github/workflows/daily-build.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/daily-build.yml b/.github/workflows/daily-build.yml index 60b697b2..3efd1a1c 100644 --- a/.github/workflows/daily-build.yml +++ b/.github/workflows/daily-build.yml @@ -75,7 +75,7 @@ jobs: file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} use_hdf: ${{ needs.get-old-names.outputs.hdf5-name }} use_environ: snapshots - if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} + if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} call-workflow-ctest: needs: [get-old-names, call-workflow-tarball] @@ -108,7 +108,6 @@ jobs: use_hdf: ${{ needs.get-old-names.outputs.hdf5-name }} file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} use_environ: snapshots - if: ${{ github.event_name != 'pull_request' }} call-workflow-release: needs: [get-old-names, call-workflow-tarball, call-workflow-ctest] @@ -121,7 +120,7 @@ jobs: file_sha: ${{ needs.call-workflow-tarball.outputs.file_sha }} use_tag: snapshot use_environ: snapshots - if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} + if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} call-workflow-remove: needs: [get-old-names, call-workflow-tarball, call-workflow-ctest, call-workflow-release] @@ -132,7 +131,7 @@ jobs: file_base: ${{ needs.get-old-names.outputs.plugin-name }} use_tag: snapshot use_environ: snapshots - if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) && (needs.get-old-names.outputs.hdf5-name != needs.call-workflow-tarball.outputs.file_base) }} + if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) && (needs.get-old-names.outputs.hdf5-name != needs.call-workflow-tarball.outputs.file_base) }} call-workflow-versions: uses: ./.github/workflows/check-releases.yml From a93c5196892eea5bb1310fa1e00ec2273b274810 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 17:25:54 -0600 Subject: [PATCH 13/16] test --- config/cmake/binex/example/CMakeLists.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/config/cmake/binex/example/CMakeLists.txt b/config/cmake/binex/example/CMakeLists.txt index c0fe3353..2ad975fa 100644 --- a/config/cmake/binex/example/CMakeLists.txt +++ b/config/cmake/binex/example/CMakeLists.txt @@ -103,7 +103,7 @@ if (H5PL_BUILD_TESTING) -D "GREP_ERRREF=Filter present but encoding disabled" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname}-ERR PROPERTIES DEPENDS ${testname}-clearall) @@ -126,7 +126,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.tst" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname} PROPERTIES DEPENDS ${testname}-clearall) @@ -165,7 +165,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) else () @@ -183,7 +183,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_BINARY_DIR}/../plugins" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) endif () From 09ea2acd1c54fa07c1c00e16136a4c1c2f28e8b7 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 19:01:39 -0600 Subject: [PATCH 14/16] testing --- config/cmake/binex/example/CMakeLists.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/config/cmake/binex/example/CMakeLists.txt b/config/cmake/binex/example/CMakeLists.txt index 2ad975fa..ad36ff89 100644 --- a/config/cmake/binex/example/CMakeLists.txt +++ b/config/cmake/binex/example/CMakeLists.txt @@ -103,7 +103,7 @@ if (H5PL_BUILD_TESTING) -D "GREP_ERRREF=Filter present but encoding disabled" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname}-ERR PROPERTIES DEPENDS ${testname}-clearall) @@ -126,7 +126,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.tst" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname} PROPERTIES DEPENDS ${testname}-clearall) @@ -165,7 +165,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) else () @@ -183,7 +183,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) endif () From c41f02942b3eb2dd47eef5caad9db429e704efa4 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 19:19:00 -0600 Subject: [PATCH 15/16] address windows --- config/cmake/binex/example/CMakeLists.txt | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/config/cmake/binex/example/CMakeLists.txt b/config/cmake/binex/example/CMakeLists.txt index ad36ff89..7054735f 100644 --- a/config/cmake/binex/example/CMakeLists.txt +++ b/config/cmake/binex/example/CMakeLists.txt @@ -67,6 +67,15 @@ foreach (example ${dyn_examples} ${extra_examples}) endforeach () if (H5PL_BUILD_TESTING) + # Set plugin path relative to PROJECT_SOURCE_DIR + # Windows: HDF5/HDFPLExamples/example -> ../../lib/plugin + # Unix/Mac: HDF5/share/HDFPLExamples/example -> ../../../lib/plugin + if (WIN32) + set (PLUGIN_RELATIVE_PATH "../../lib/plugin") + else () + set (PLUGIN_RELATIVE_PATH "../../../lib/plugin") + endif () + macro (ADD_H5_TEST testname) add_test ( NAME ${testname}-clearall @@ -103,7 +112,7 @@ if (H5PL_BUILD_TESTING) -D "GREP_ERRREF=Filter present but encoding disabled" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/${PLUGIN_RELATIVE_PATH}" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname}-ERR PROPERTIES DEPENDS ${testname}-clearall) @@ -126,7 +135,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.tst" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/${PLUGIN_RELATIVE_PATH}" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) set_tests_properties (${testname} PROPERTIES DEPENDS ${testname}-clearall) @@ -165,7 +174,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/${PLUGIN_RELATIVE_PATH}" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) else () @@ -183,7 +192,7 @@ if (H5PL_BUILD_TESTING) -D "TEST_REFERENCE=${testname}.ddl" -D "TEST_LIBRARY_DIRECTORY=${TESTLIBDIR}" -D "TEST_ENV_VAR=HDF5_PLUGIN_PATH" - -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/../../../lib/plugin" + -D "TEST_ENV_VALUE=${PROJECT_SOURCE_DIR}/${PLUGIN_RELATIVE_PATH}" -P "${H5PL_RESOURCES_DIR}/runTest.cmake" ) endif () From a753009c0a1c0ee97630c8ef4c6859912df600f7 Mon Sep 17 00:00:00 2001 From: Scot Breitenfeld Date: Mon, 5 Jan 2026 19:27:10 -0600 Subject: [PATCH 16/16] fixed release-related actions --- .github/workflows/daily-build.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/daily-build.yml b/.github/workflows/daily-build.yml index 3efd1a1c..60b697b2 100644 --- a/.github/workflows/daily-build.yml +++ b/.github/workflows/daily-build.yml @@ -75,7 +75,7 @@ jobs: file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} use_hdf: ${{ needs.get-old-names.outputs.hdf5-name }} use_environ: snapshots - if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} + if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} call-workflow-ctest: needs: [get-old-names, call-workflow-tarball] @@ -108,6 +108,7 @@ jobs: use_hdf: ${{ needs.get-old-names.outputs.hdf5-name }} file_base: ${{ needs.call-workflow-tarball.outputs.file_base }} use_environ: snapshots + if: ${{ github.event_name != 'pull_request' }} call-workflow-release: needs: [get-old-names, call-workflow-tarball, call-workflow-ctest] @@ -120,7 +121,7 @@ jobs: file_sha: ${{ needs.call-workflow-tarball.outputs.file_sha }} use_tag: snapshot use_environ: snapshots - if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} + if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) }} call-workflow-remove: needs: [get-old-names, call-workflow-tarball, call-workflow-ctest, call-workflow-release] @@ -131,7 +132,7 @@ jobs: file_base: ${{ needs.get-old-names.outputs.plugin-name }} use_tag: snapshot use_environ: snapshots - if: ${{ ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) && (needs.get-old-names.outputs.hdf5-name != needs.call-workflow-tarball.outputs.file_base) }} + if: ${{ (github.event_name != 'pull_request') && ((needs.call-workflow-tarball.outputs.has_changes == 'true') || (needs.get-old-names.outputs.run-ignore == 'ignore')) && (needs.get-old-names.outputs.hdf5-name != needs.call-workflow-tarball.outputs.file_base) }} call-workflow-versions: uses: ./.github/workflows/check-releases.yml