Skip to content

Commit bff410c

Browse files
authored
refactor: ♻️ unique ids optional_dependencies - dependencies (#308)
Added validation to check for the same mod_ids in `optional_dependencies` and `dependencies` Technically, it may break mods that have the same `mod_id` listed in both the `optional_dependencies` and `dependencies` sections. However, since the `optional_dependencies` feature was introduced in v6.0.0, it is highly unlikely that such conflicts exist.
1 parent cc2103f commit bff410c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

addons/mod_loader/resources/mod_manifest.gd

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,12 @@ func _init(manifest: Dictionary) -> void:
110110
incompatibilities,
111111
["dependencies", "incompatibilities"]
112112
) or
113+
not validate_distinct_mod_ids_in_arrays(
114+
mod_id,
115+
optional_dependencies,
116+
dependencies,
117+
["optional_dependencies", "dependencies"]
118+
) or
113119
not validate_distinct_mod_ids_in_arrays(
114120
mod_id,
115121
optional_dependencies,

0 commit comments

Comments
 (0)