sort as int if key is a number when decoding maps to lists as although rtdb show numeric string keys in numeric order they are returned by the sdk in lexicographically

Author: nbransby

firebase-common/src/androidMain/kotlin/dev/gitlive/firebase/_decoders.kt

@@ -20,9 +20,16 @@ actual fun FirebaseDecoder.structureDecoder(descriptor: SerialDescriptor): Compo
                 }
             }
         }
-        StructureKind.LIST -> ((value as? Map<*, *>)?.values?.toList() ?: value as List<*>).let {
-            FirebaseCompositeDecoder(it.size) { _, index -> it[index] }
-        }
+        StructureKind.LIST ->
+            when(value) {
+                is List<*> -> value
+                is Map<*, *> -> value.asSequence()
+                    .sortedBy { (it) -> it.toString().toIntOrNull() }
+                    .map { (_, it) -> it }
+                    .toList()
+                else -> error("unexpected type, got $value when expecting a list")
+            }
+            .let { FirebaseCompositeDecoder(it.size) { _, index -> it[index] } }
         StructureKind.MAP -> (value as Map<*, *>).entries.toList().let {
             FirebaseCompositeDecoder(it.size) { _, index -> it[index/2].run { if(index % 2 == 0) key else value }  }
         }

firebase-common/src/iosMain/kotlin/dev/gitlive/firebase/_decoders.kt

@@ -20,9 +20,16 @@ actual fun FirebaseDecoder.structureDecoder(descriptor: SerialDescriptor): Compo
             }
         }
     }
-    StructureKind.LIST -> ((value as? Map<*, *>)?.values?.toList() ?: value as List<*>).let {
-        FirebaseCompositeDecoder(it.size) { _, index -> it[index] }
-    }
+    StructureKind.LIST ->
+        when(value) {
+            is List<*> -> value
+            is Map<*, *> -> value.asSequence()
+                .sortedBy { (it) -> it.toString().toIntOrNull() }
+                .map { (_, it) -> it }
+                .toList()
+            else -> error("unexpected type, got $value when expecting a list")
+        }
+        .let { FirebaseCompositeDecoder(it.size) { _, index -> it[index] } }
     StructureKind.MAP -> (value as Map<*, *>).entries.toList().let {
         FirebaseCompositeDecoder(it.size) { _, index -> it[index/2].run { if(index % 2 == 0) key else value }  }
     }

firebase-common/src/jsMain/kotlin/dev/gitlive/firebase/_decoders.kt

@@ -22,9 +22,16 @@ actual fun FirebaseDecoder.structureDecoder(descriptor: SerialDescriptor): Compo
             }
         }
     }
-    StructureKind.LIST -> (js("Object").values(value) as Array<*>).let {
-        FirebaseCompositeDecoder(it.size) { _, index -> it[index] }
-    }
+    StructureKind.LIST ->
+        when(value) {
+            is Array<*> -> value
+            else -> (js("Object").entries(value) as Array<Array<Any>>)
+                .asSequence()
+                .sortedBy { (it) -> it.toString().toIntOrNull() }
+                .map { (_, it) -> it }
+                .toList()
+        }
+        .let { FirebaseCompositeDecoder(it.size) { _, index -> it[index] } }
     StructureKind.MAP -> (js("Object").entries(value) as Array<Array<Any>>).let {
         FirebaseCompositeDecoder(it.size) { _, index -> it[index/2].run { if(index % 2 == 0) get(0) else get(1) } }
     }