Skip to content

Commit 172e62d

Browse files
committed
Revert "chore: prevent logging to stdout, reserved for MCP JSON-RPC protocol"
This reverts commit 03bcf59.
1 parent 80a33c8 commit 172e62d

File tree

3 files changed

+8
-20
lines changed
  • packages

3 files changed

+8
-20
lines changed

packages/developer_mcp_server/src/developer_mcp_server/server.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,21 @@
22

33
import logging
44

5-
from gg_api_core import configure_mcp_logging
65
from gg_api_core.mcp_server import get_mcp_server
76
from gg_api_core.scopes import set_developer_scopes
87

98
from developer_mcp_server.add_health_check import add_health_check
109
from developer_mcp_server.register_tools import DEVELOPER_INSTRUCTIONS, register_developer_tools
1110

12-
configure_mcp_logging()
11+
# Configure more detailed logging
12+
logging.basicConfig(level=logging.DEBUG, format="%(asctime)s - %(name)s - %(levelname)s - %(message)s")
13+
1314
logger = logging.getLogger(__name__)
1415

1516
# Use our custom GitGuardianFastMCP from the core package
1617
mcp = get_mcp_server(
1718
"GitGuardian Developer",
19+
log_level="DEBUG",
1820
instructions=DEVELOPER_INSTRUCTIONS,
1921
)
2022

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,3 @@
11
"""Core functionality for GitGuardian MCP servers."""
22

3-
import logging
4-
import sys
5-
63
__version__ = "0.1.0"
7-
8-
9-
def configure_mcp_logging(level: int = logging.INFO) -> None:
10-
"""Configure logging to use stderr (stdout is reserved for MCP JSON-RPC protocol)."""
11-
logging.basicConfig(
12-
level=level,
13-
format="%(asctime)s - %(name)s - %(levelname)s - %(message)s",
14-
stream=sys.stderr,
15-
force=True,
16-
)
17-
# Reduce noise from library loggers
18-
for name in ("mcp", "fastmcp", "rich"):
19-
logging.getLogger(name).setLevel(logging.WARNING)

packages/secops_mcp_server/src/secops_mcp_server/server.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from developer_mcp_server.add_health_check import add_health_check
77
from developer_mcp_server.register_tools import register_developer_tools
88
from fastmcp.exceptions import ToolError
9-
from gg_api_core import configure_mcp_logging
109
from gg_api_core.mcp_server import get_mcp_server, register_common_tools
1110
from gg_api_core.scopes import set_secops_scopes
1211
from gg_api_core.tools.assign_incident import assign_incident
@@ -18,7 +17,9 @@
1817
from gg_api_core.tools.write_custom_tags import update_or_create_incident_custom_tags, write_custom_tags
1918
from pydantic import BaseModel, Field
2019

21-
configure_mcp_logging()
20+
# Configure more detailed logging
21+
logging.basicConfig(level=logging.DEBUG, format="%(asctime)s - %(name)s - %(levelname)s - %(message)s")
22+
2223
logger = logging.getLogger(__name__)
2324

2425

@@ -112,6 +113,7 @@ class ListHoneytokensParams(BaseModel):
112113
# Use our custom GitGuardianFastMCP from the core package
113114
mcp = get_mcp_server(
114115
"GitGuardian SecOps",
116+
log_level="DEBUG",
115117
instructions=SECOPS_INSTRUCTIONS,
116118
)
117119

0 commit comments

Comments
 (0)