Skip to content

Fix reading messages from muted users #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laevandus wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix reading messages from muted users #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20f4569
Fix reading messages from muted users
laevandus Dec 3, 2025
c10a0ca
CHANGELOG entry
laevandus Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

# Upcoming

### 🔄 Changed
### 🐞 Fixed
- Fix reading messages from muted users [#1063](https://github.com/GetStream/stream-chat-swiftui/pull/1063)

# [4.94.0](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.94.0)
_December 02, 2025_
Expand Down
5 changes: 3 additions & 2 deletions Sources/StreamChatSwiftUI/ChatChannel/ChatChannelViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,11 @@ open class ChatChannelViewModel: ObservableObject, MessagesDataSource {
}

private func sendReadEventIfNeeded(for message: ChatMessage) {
guard let channel, channel.unreadCount.messages > 0 else {
Copy link
Contributor Author

@laevandus laevandus Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since unread count did not change when a muted user sent a message then we never called mark read

Copy link
Member

@nuno-vieira nuno-vieira Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the same issue on UIKit? I think I introduced this logic recently in UIKit as well 🤔

guard let channel, let currentUserId = chatClient.currentUserId else { return }
if currentUserMarkedMessageUnread {
return
}
if currentUserMarkedMessageUnread {
if let read = channel.read(for: currentUserId), read.lastReadAt > message.createdAt {
return
}
throttler.execute { [weak self] in
Expand Down
29 changes: 27 additions & 2 deletions StreamChatSwiftUITests/Tests/ChatChannel/ChatChannelViewModel_Tests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,11 +740,36 @@ class ChatChannelViewModel_Tests: StreamChatTestCase {
XCTAssertEqual(1, channelController.markReadCallCount)
}

func test_chatChannelVM_sendReadEventIfNeeded_whenChannelHasNoUnreadMessages() {
func test_chatChannelVM_sendReadEventIfNeeded_whenChannelHasNoReads_thenMarkReadIsCalled() {
// Given
let message = ChatMessage.mock()
let channelController = makeChannelController(messages: [message])
channelController.channel_mock = .mock(cid: .unique, unreadCount: ChannelUnreadCount(messages: 0, mentions: 0))
channelController.channel_mock = .mockDMChannel(reads: [])
channelController.hasLoadedAllNextMessages_mock = true
let viewModel = ChatChannelViewModel(channelController: channelController)
viewModel.currentUserMarkedMessageUnread = false
viewModel.throttler = Throttler_Mock(interval: 0)

// When
viewModel.handleMessageAppear(index: 0, scrollDirection: .down)

// Then
XCTAssertEqual(1, channelController.markReadCallCount)
}

func test_chatChannelVM_sendReadEventIfNeeded_whenChannelReadHasMoreRecentTimestamp_thenMarkReadIsNotCalled() {
// Given
let message = ChatMessage.mock()
let channelController = makeChannelController(messages: [message])
channelController.channel_mock = .mockDMChannel(
reads: [.mock(
lastReadAt: .distantFuture,
lastReadMessageId: .unique,
unreadMessagesCount: 0,
user: .mock(id: chatClient.currentUserId ?? "")
)]
)
channelController.hasLoadedAllNextMessages_mock = true
let viewModel = ChatChannelViewModel(channelController: channelController)
viewModel.currentUserMarkedMessageUnread = false
viewModel.throttler = Throttler_Mock(interval: 0)
Expand Down
Loading