From dc4d235439924ee20088ee798ae6db316de73ac1 Mon Sep 17 00:00:00 2001 From: nijeeshjoshy Date: Wed, 19 Nov 2025 15:59:53 +0100 Subject: [PATCH 1/4] changed filter conditions to filter --- .../java/io/getstream/chat/java/models/Reminder.java | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/main/java/io/getstream/chat/java/models/Reminder.java b/src/main/java/io/getstream/chat/java/models/Reminder.java index 2205f0417..b7d94d0c7 100644 --- a/src/main/java/io/getstream/chat/java/models/Reminder.java +++ b/src/main/java/io/getstream/chat/java/models/Reminder.java @@ -18,7 +18,6 @@ import lombok.Builder; import lombok.Data; import lombok.EqualsAndHashCode; -import lombok.Getter; import lombok.NoArgsConstructor; import lombok.RequiredArgsConstructor; import lombok.Singular; @@ -81,8 +80,6 @@ public void setAdditionalField(String name, Object value) { builderClassName = "ReminderCreateRequest", builderMethodName = "", buildMethodName = "internalBuild") - @Getter - @EqualsAndHashCode public static class ReminderCreateRequestData { @NotNull @JsonProperty("user_id") @@ -110,8 +107,6 @@ protected Call generateCall(Client client) { builderClassName = "ReminderUpdateRequest", builderMethodName = "", buildMethodName = "internalBuild") - @Getter - @EqualsAndHashCode public static class ReminderUpdateRequestData { @NotNull @JsonProperty("user_id") @@ -135,8 +130,6 @@ protected Call generateCall(Client client) { } } - @Getter - @EqualsAndHashCode @RequiredArgsConstructor public static class ReminderDeleteRequest extends StreamRequest { @NotNull private String messageId; @@ -152,8 +145,6 @@ protected Call generateCall(Client client) { builderClassName = "ReminderQueryRequest", builderMethodName = "", buildMethodName = "internalBuild") - @Getter - @EqualsAndHashCode public static class ReminderQueryRequestData { @NotNull @JsonProperty("user_id") @@ -161,7 +152,7 @@ public static class ReminderQueryRequestData { @Singular @Nullable - @JsonProperty("filter_conditions") + @JsonProperty("filter") private Map filterConditions; @Singular From aa33cf9d89ceb07488eafb7e3b7b572bb0ead49d Mon Sep 17 00:00:00 2001 From: nijeeshjoshy Date: Wed, 19 Nov 2025 16:04:13 +0100 Subject: [PATCH 2/4] updated testcases --- src/test/java/io/getstream/chat/java/ReminderTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/io/getstream/chat/java/ReminderTest.java b/src/test/java/io/getstream/chat/java/ReminderTest.java index 050fe12ad..a3bdb721f 100644 --- a/src/test/java/io/getstream/chat/java/ReminderTest.java +++ b/src/test/java/io/getstream/chat/java/ReminderTest.java @@ -167,9 +167,9 @@ void whenQueryingRemindersWithFilterConditions_thenNoException() { // Verify the query returned results Assertions.assertNotNull(reminders); - // Note: The API might not return any reminders if they were deleted or not indexed yet - // So we don't assert that the list is not empty - + Assertions.assertEquals(1, reminders.size()); + Assertions.assertEquals(message.getId(), reminders.get(0).getMessageId()); + // Check for pagination fields Assertions.assertDoesNotThrow( () -> { From 6e63c449ed7fef18fe7970da3ba19ce6d8cbba7f Mon Sep 17 00:00:00 2001 From: nijeeshjoshy Date: Wed, 19 Nov 2025 16:06:29 +0100 Subject: [PATCH 3/4] removed unwanted changes --- .../java/io/getstream/chat/java/models/Reminder.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/main/java/io/getstream/chat/java/models/Reminder.java b/src/main/java/io/getstream/chat/java/models/Reminder.java index b7d94d0c7..a1b4df843 100644 --- a/src/main/java/io/getstream/chat/java/models/Reminder.java +++ b/src/main/java/io/getstream/chat/java/models/Reminder.java @@ -18,6 +18,7 @@ import lombok.Builder; import lombok.Data; import lombok.EqualsAndHashCode; +import lombok.Getter; import lombok.NoArgsConstructor; import lombok.RequiredArgsConstructor; import lombok.Singular; @@ -80,6 +81,8 @@ public void setAdditionalField(String name, Object value) { builderClassName = "ReminderCreateRequest", builderMethodName = "", buildMethodName = "internalBuild") + @Getter + @EqualsAndHashCode public static class ReminderCreateRequestData { @NotNull @JsonProperty("user_id") @@ -107,6 +110,8 @@ protected Call generateCall(Client client) { builderClassName = "ReminderUpdateRequest", builderMethodName = "", buildMethodName = "internalBuild") + @Getter + @EqualsAndHashCode public static class ReminderUpdateRequestData { @NotNull @JsonProperty("user_id") @@ -130,6 +135,8 @@ protected Call generateCall(Client client) { } } + @Getter + @EqualsAndHashCode @RequiredArgsConstructor public static class ReminderDeleteRequest extends StreamRequest { @NotNull private String messageId; @@ -145,6 +152,8 @@ protected Call generateCall(Client client) { builderClassName = "ReminderQueryRequest", builderMethodName = "", buildMethodName = "internalBuild") + @Getter + @EqualsAndHashCode public static class ReminderQueryRequestData { @NotNull @JsonProperty("user_id") From 1c941f6fb3e42208f07f5022088f86652b69002b Mon Sep 17 00:00:00 2001 From: nijeeshjoshy Date: Wed, 19 Nov 2025 16:16:19 +0100 Subject: [PATCH 4/4] fixed linting --- src/test/java/io/getstream/chat/java/ReminderTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/io/getstream/chat/java/ReminderTest.java b/src/test/java/io/getstream/chat/java/ReminderTest.java index a3bdb721f..21930e031 100644 --- a/src/test/java/io/getstream/chat/java/ReminderTest.java +++ b/src/test/java/io/getstream/chat/java/ReminderTest.java @@ -169,7 +169,7 @@ void whenQueryingRemindersWithFilterConditions_thenNoException() { Assertions.assertNotNull(reminders); Assertions.assertEquals(1, reminders.size()); Assertions.assertEquals(message.getId(), reminders.get(0).getMessageId()); - + // Check for pagination fields Assertions.assertDoesNotThrow( () -> {