From 0c1e54c788b64c7226c1806ddc9eca869a742146 Mon Sep 17 00:00:00 2001 From: javierdfm Date: Wed, 22 Oct 2025 16:35:39 +0200 Subject: [PATCH 1/2] fix: fix message count test after ff removal --- .../io/getstream/chat/java/MessageCountTest.java | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/test/java/io/getstream/chat/java/MessageCountTest.java b/src/test/java/io/getstream/chat/java/MessageCountTest.java index 132cf564d..3b6fe7bf7 100644 --- a/src/test/java/io/getstream/chat/java/MessageCountTest.java +++ b/src/test/java/io/getstream/chat/java/MessageCountTest.java @@ -3,6 +3,9 @@ import io.getstream.chat.java.models.Channel; import io.getstream.chat.java.models.Channel.ChannelGetResponse; import io.getstream.chat.java.models.Channel.ChannelRequestObject; +import io.getstream.chat.java.models.ChannelType.ChannelTypeCreateResponse; +import io.getstream.chat.java.models.ChannelType.ChannelTypeGetResponse; +import io.getstream.chat.java.models.ChannelType; import io.getstream.chat.java.models.Message; import io.getstream.chat.java.models.Message.MessageRequestObject; import java.util.HashMap; @@ -17,11 +20,14 @@ public class MessageCountTest extends BasicTest { @DisplayName("Message count is present when feature enabled") @Test void whenCountMessagesEnabled_thenMessagesCount() { - // Create a fresh channel with default configuration (count_messages enabled by default) + // Enable count_messages on the built-in "messaging" channel type + Assertions.assertDoesNotThrow(() -> ChannelType.update("messaging").countMessages(true).request()); + pause(); + ChannelGetResponse channelGetResponse = Assertions.assertDoesNotThrow( () -> - Channel.getOrCreate("team", RandomStringUtils.randomAlphabetic(12)) + Channel.getOrCreate("messaging", RandomStringUtils.randomAlphabetic(12)) .data( ChannelRequestObject.builder() .createdBy(testUserRequestObject) @@ -47,6 +53,9 @@ void whenCountMessagesEnabled_thenMessagesCount() { Assertions.assertTrue( refreshed.getChannel().getMessageCount() == 1, "messages_count should be 1 when count_messages is enabled"); + + // Cleanup: delete channel created for this test + Assertions.assertDoesNotThrow(() -> Channel.delete(type, id).request()); } @DisplayName("Message count is not returned when feature disabled") @@ -87,5 +96,8 @@ void whenCountMessagesDisabled_thenNoMessageCountPresent() { Integer messagesCount = refreshed.getChannel().getMessageCount(); Assertions.assertNull( messagesCount, "messages_count should not be present when count_messages is disabled"); + + // Cleanup: delete channel created for this test + Assertions.assertDoesNotThrow(() -> Channel.delete(type, id).request()); } } From 94d670726e7c9c25953e0ce6e529c07cf6731da3 Mon Sep 17 00:00:00 2001 From: javierdfm Date: Wed, 22 Oct 2025 16:38:10 +0200 Subject: [PATCH 2/2] fix: spotlessapply --- src/test/java/io/getstream/chat/java/MessageCountTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/java/io/getstream/chat/java/MessageCountTest.java b/src/test/java/io/getstream/chat/java/MessageCountTest.java index 3b6fe7bf7..393b7708e 100644 --- a/src/test/java/io/getstream/chat/java/MessageCountTest.java +++ b/src/test/java/io/getstream/chat/java/MessageCountTest.java @@ -3,8 +3,6 @@ import io.getstream.chat.java.models.Channel; import io.getstream.chat.java.models.Channel.ChannelGetResponse; import io.getstream.chat.java.models.Channel.ChannelRequestObject; -import io.getstream.chat.java.models.ChannelType.ChannelTypeCreateResponse; -import io.getstream.chat.java.models.ChannelType.ChannelTypeGetResponse; import io.getstream.chat.java.models.ChannelType; import io.getstream.chat.java.models.Message; import io.getstream.chat.java.models.Message.MessageRequestObject; @@ -21,7 +19,8 @@ public class MessageCountTest extends BasicTest { @Test void whenCountMessagesEnabled_thenMessagesCount() { // Enable count_messages on the built-in "messaging" channel type - Assertions.assertDoesNotThrow(() -> ChannelType.update("messaging").countMessages(true).request()); + Assertions.assertDoesNotThrow( + () -> ChannelType.update("messaging").countMessages(true).request()); pause(); ChannelGetResponse channelGetResponse =