fix many ruff issues

Author: Galarzaa90

pyproject.toml

@@ -171,6 +171,7 @@ ignore = [
     "RUF012",
     # PEP 484 prohibits implicit `Optional`
     "RUF013",
+
     # Missing type annotation for {name} in method
     "ANN101",
     # Missing type annotation for {name} in classmethod
@@ -179,6 +180,8 @@ ignore = [
     "ANN202",
     # Missing return type annotation for special method {name}
     "ANN204",
+    # Dynamically typed expressions ({name}) are disallowed in `other`
+    "ANN401",
 ]
 
 

tibiapy/builders/bazaar.py

@@ -51,7 +51,7 @@ def filters(self, filters: AuctionFilters) -> Self:
         self._filters = filters
         return self
 
-    def build(self):
+    def build(self) -> CharacterBazaar:
         return CharacterBazaar(
             current_page=self._current_page,
             total_pages=self._total_pages,
@@ -143,7 +143,7 @@ def status(self, status: AuctionStatus) -> Self:
         self._status = status
         return self
 
-    def build(self):
+    def build(self) -> Auction:
         return Auction(
             auction_id=self._auction_id,
             name=self._name,
@@ -399,7 +399,7 @@ def add_revealed_gem(self, gem: RevealedGem) -> Self:
         self._revealed_gems.append(gem)
         return self
 
-    def build(self):
+    def build(self) -> AuctionDetails:
         return AuctionDetails(
             hit_points=self._hit_points,
             mana=self._mana,

tibiapy/builders/character.py

@@ -166,7 +166,7 @@ def other_characters(self, other_characters: List[OtherCharacter]) -> Self:
         self._other_characters = other_characters
         return self
 
-    def build(self):
+    def build(self) -> Character:
         return Character(
             name=self._name,
             is_traded=self._traded,

tibiapy/builders/creature.py

@@ -21,7 +21,7 @@ def identifier(self, identifier: str) -> Self:
         self._identifier = identifier
         return self
 
-    def build(self):
+    def build(self) -> CreatureEntry:
         return CreatureEntry(
             name=self._name,
             identifier=self._identifier,
@@ -91,7 +91,7 @@ def convinceable(self, convinceable: bool) -> Self:
         self._convinceable = convinceable
         return self
 
-    def build(self):
+    def build(self) -> Creature:
         return Creature(
             name=self._name,
             identifier=self._identifier,

tibiapy/builders/event.py

@@ -32,7 +32,7 @@ def add_event(self, event: EventEntry) -> Self:
         self._events.append(event)
         return self
 
-    def build(self):
+    def build(self) -> EventSchedule:
         return EventSchedule(
             month=self._month,
             year=self._year,

tibiapy/builders/forum.py

@@ -45,7 +45,7 @@ def add_entry(self, entry) -> Self:
         self._entries.append(entry)
         return self
 
-    def build(self):
+    def build(self) -> CMPostArchive:
         return CMPostArchive(
             from_date=self._from_date,
             to_date=self._to_date,
@@ -79,7 +79,7 @@ def thread_title(self, thread_title) -> Self:
         self._thread_title = thread_title
         return self
 
-    def build(self):
+    def build(self) -> CMPost:
         return CMPost(
             post_id=self._post_id,
             posted_on=self._posted_on,
@@ -141,7 +141,7 @@ def to_date(self, to_date) -> Self:
         self._to_date = to_date
         return self
 
-    def build(self):
+    def build(self) -> ForumAnnouncement:
         return ForumAnnouncement(
             announcement_id=self._announcement_id,
             board=self._board,
@@ -217,7 +217,7 @@ def add_entry(self, entry) -> Self:
         self._entries.append(entry)
         return self
 
-    def build(self):
+    def build(self) -> ForumBoard:
         return ForumBoard(
             board_id=self._board_id,
             name=self._name,
@@ -303,7 +303,7 @@ def add_entry(self, entry) -> Self:
         self._entries.append(entry)
         return self
 
-    def build(self):
+    def build(self) -> ForumThread:
         return ForumThread(
             title=self._title,
             thread_id=self._thread_id,

tibiapy/builders/guild.py

@@ -48,7 +48,7 @@ def active(self, active: bool) -> Self:
         self._active = active
         return self
 
-    def build(self):
+    def build(self) -> GuildEntry:
         return GuildEntry(
             name=self._name,
             logo_url=self._logo_url,
@@ -128,7 +128,7 @@ def add_invite(self, invite: GuildInvite) -> Self:
         self._invites.append(invite)
         return self
 
-    def build(self):
+    def build(self) -> Guild:
         return Guild(
             name=self._name,
             logo_url=self._logo_url,
@@ -166,7 +166,7 @@ def history(self, history: List[GuildWarEntry]) -> Self:
         self._history = history
         return self
 
-    def build(self):
+    def build(self) -> GuildWars:
         return GuildWars(
             name=self._name,
             history=self._history,
@@ -237,7 +237,7 @@ def surrender(self, surrender: bool) -> Self:
         self._surrender = surrender
         return self
 
-    def build(self):
+    def build(self) -> GuildWarEntry:
         return GuildWarEntry(
             guild_name=self._guild_name,
             guild_score=self._guild_score,

tibiapy/builders/highscores.py

@@ -74,7 +74,7 @@ def available_worlds(self, available_worlds: List[str]) -> Self:
         self._available_worlds = available_worlds
         return self
 
-    def build(self):
+    def build(self) -> Highscores:
         return Highscores(
             world=self._world,
             category=self._category,

tibiapy/builders/house.py

@@ -3,6 +3,8 @@
 
 from typing import List, TYPE_CHECKING, Optional
 
+from typing_extensions import Self
+
 from tibiapy.models.house import HouseEntry, HousesSection, House
 
 if TYPE_CHECKING:
@@ -21,43 +23,43 @@ def __init__(self):
         self._available_worlds = []
         self._available_towns = []
 
-    def world(self, world: str):
+    def world(self, world: str) -> Self:
         self._world = world
         return self
 
-    def town(self, town: str):
+    def town(self, town: str) -> Self:
         self._town = town
         return self
 
-    def status(self, status: HouseStatus):
+    def status(self, status: HouseStatus) -> Self:
         self._status = status
         return self
 
-    def house_type(self, house_type: HouseType):
+    def house_type(self, house_type: HouseType) -> Self:
         self._house_type = house_type
         return self
 
-    def order(self, order: HouseOrder):
+    def order(self, order: HouseOrder) -> Self:
         self._order = order
         return self
 
-    def entries(self, entries: List[HouseEntry]):
+    def entries(self, entries: List[HouseEntry]) -> Self:
         self._entries = entries
         return self
 
-    def add_entry(self, entry: HouseEntry):
+    def add_entry(self, entry: HouseEntry) -> Self:
         self._entries.append(entry)
         return self
 
-    def available_worlds(self, available_worlds: List[str]):
+    def available_worlds(self, available_worlds: List[str]) -> Self:
         self._available_worlds = available_worlds
         return self
 
-    def available_towns(self, available_towns: List[str]):
+    def available_towns(self, available_towns: List[str]) -> Self:
         self._available_towns = available_towns
         return self
 
-    def build(self):
+    def build(self) -> HousesSection:
         return HousesSection(
             world=self._world,
             town=self._town,
@@ -100,35 +102,35 @@ def __init__(self):
         self._time_left = None
         self._highest_bid = None
 
-    def status(self, status: HouseStatus):
+    def status(self, status: HouseStatus) -> Self:
         self._status = status
         return self
 
-    def type(self, type: HouseType):
+    def type(self, type: HouseType) -> Self:
         self._type = type
         return self
 
-    def town(self, town: str):
+    def town(self, town: str) -> Self:
         self._town = town
         return self
 
-    def size(self, size: int):
+    def size(self, size: int) -> Self:
         self._size = size
         return self
 
-    def rent(self, rent: int):
+    def rent(self, rent: int) -> Self:
         self._rent = rent
         return self
 
-    def time_left(self, time_left: Optional[datetime.timedelta]):
+    def time_left(self, time_left: Optional[datetime.timedelta]) -> Self:
         self._time_left = time_left
         return self
 
-    def highest_bid(self, highest_bid: Optional[int]):
+    def highest_bid(self, highest_bid: Optional[int]) -> Self:
         self._highest_bid = highest_bid
         return self
 
-    def build(self):
+    def build(self) -> HouseEntry:
         return HouseEntry(
             name=self._name,
             id=self._id,
@@ -163,71 +165,71 @@ def __init__(self):
         self._highest_bidder = None
         self._auction_end = None
 
-    def status(self, status: HouseStatus):
+    def status(self, status: HouseStatus) -> Self:
         self._status = status
         return self
 
-    def rent(self, rent: int):
+    def rent(self, rent: int) -> Self:
         self._rent = rent
         return self
 
-    def type(self, type: HouseType):
+    def type(self, type: HouseType) -> Self:
         self._type = type
         return self
 
-    def image_url(self, image_url: str):
+    def image_url(self, image_url: str) -> Self:
         self._image_url = image_url
         return self
 
-    def beds(self, beds: int):
+    def beds(self, beds: int) -> Self:
         self._beds = beds
         return self
 
-    def size(self, size: int):
+    def size(self, size: int) -> Self:
         self._size = size
         return self
 
-    def owner(self, owner: Optional[str]):
+    def owner(self, owner: Optional[str]) -> Self:
         self._owner = owner
         return self
 
-    def owner_sex(self, owner_sex: Sex):
+    def owner_sex(self, owner_sex: Sex) -> Self:
         self._owner_sex = owner_sex
         return self
 
-    def paid_until(self, paid_until: Optional[datetime.datetime]):
+    def paid_until(self, paid_until: Optional[datetime.datetime]) -> Self:
         self._paid_until = paid_until
         return self
 
-    def transfer_date(self, transfer_date: Optional[datetime.datetime]):
+    def transfer_date(self, transfer_date: Optional[datetime.datetime]) -> Self:
         self._transfer_date = transfer_date
         return self
 
-    def transfer_recipient(self, transfer_recipient: Optional[str]):
+    def transfer_recipient(self, transfer_recipient: Optional[str]) -> Self:
         self._transfer_recipient = transfer_recipient
         return self
 
-    def transfer_price(self, transfer_price: Optional[int]):
+    def transfer_price(self, transfer_price: Optional[int]) -> Self:
         self._transfer_price = transfer_price
         return self
 
-    def transfer_accepted(self, transfer_accepted: Optional[bool]):
+    def transfer_accepted(self, transfer_accepted: Optional[bool]) -> Self:
         self._transfer_accepted = transfer_accepted
         return self
 
-    def highest_bid(self, highest_bid: Optional[int]):
+    def highest_bid(self, highest_bid: Optional[int]) -> Self:
         self._highest_bid = highest_bid
         return self
 
-    def highest_bidder(self, highest_bidder: Optional[str]):
+    def highest_bidder(self, highest_bidder: Optional[str]) -> Self:
         self._highest_bidder = highest_bidder
         return self
 
-    def auction_end(self, auction_end: Optional[datetime.datetime]):
+    def auction_end(self, auction_end: Optional[datetime.datetime]) -> Self:
         self._auction_end = auction_end
         return self
 
-    def build(self):
+    def build(self) -> House:
         return House(
             name=self._name,
             id=self._id,

tibiapy/builders/kill_statistics.py

@@ -36,7 +36,7 @@ def available_worlds(self, available_worlds: List[str]) -> Self:
         self._available_worlds = available_worlds
         return self
 
-    def build(self):
+    def build(self) -> KillStatistics:
         return KillStatistics(
             world=self._world,
             entries=self._entries,