Working

Author: robotdan

src/main/java/io/fusionauth/http/server/Configurable.java

@@ -61,6 +61,15 @@ default T withChunkedBufferSize(int chunkedBufferSize) {
   /**
    * Sets the default compression behavior for the HTTP response. This behavior can be optionally set per response. See
    * {@link HTTPResponse#setCompress(boolean)}. Defaults to true.
+   * <p>
+   * Set this configuration to <code>true</code> if you want to compress the response when the Accept-Encoding header is present. Set this
+   * configuration to <code>false</code> if you want to require the request handler to use {@link HTTPResponse#setCompress(boolean)} in
+   * order to compress the response.
+   * <p>
+   * Regardless of this configuration, you always have the option to use {@link HTTPResponse#setCompress(boolean)} on a per-response basis
+   * as an override.
+   * <p>
+   * When the request does not contain an Accept-Encoding the response will not be compressed regardless of this configuration.
    *
    * @param compressByDefault true if you want to compress by default, or false to not compress by default.
    * @return This.

src/main/java/io/fusionauth/http/server/io/HTTPInputStream.java

@@ -135,6 +135,17 @@ public int read(byte[] b, int off, int len) throws IOException {
       return 0;
     }
 
+    // TODO : Re: Compression - fixedLength and Content-Length needs to account for the Content-Length referring to the compressed body.
+
+    // Preamble, this could push back compressed bytes.
+    //   Pushback > Throughput > Socket
+    //
+    // HTTPInputStream (this) -> Decompress > Pushback > Throughput > Socket
+    // HTTPInputStream (this) -> Decompress > Chunked > Pushback > Throughput > Socket
+    //
+    // Pushback doesn't care if the bytes are compressed or not, it is up to the caller?
+    //
+
     // If this is a fixed length request, and we have less than or equal to 0 bytes remaining, return -1
     boolean fixedLength = !request.isChunked();
     if (fixedLength && bytesRemaining <= 0) {
@@ -147,7 +158,11 @@ public int read(byte[] b, int off, int len) throws IOException {
 
     // When we have a fixed length request, read beyond the remainingBytes if possible.
     // - If we have read past the end of the current request, push those bytes back onto the InputStream.
-    int read = delegate.read(b, off, len);
+    // TODO : Can I optionally never override here? If I am fixed length, I could change len -> maxLen., and then never pushback.
+    //        Would this help with compression?
+//    int maxLen = (int) Math.min(len, bytesRemaining);
+    int maxLen = len;
+    int read = delegate.read(b, off, maxLen);
     if (fixedLength && read > 0) {
       int extraBytes = (int) (read - bytesRemaining);
       if (extraBytes > 0) {