review edits

Author: robotdan

src/main/java/io/fusionauth/http/ConnectionClosedException.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, FusionAuth, All Rights Reserved
+ * Copyright (c) 2023-2025, FusionAuth, All Rights Reserved
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/main/java/io/fusionauth/http/HTTPValues.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021-2023, FusionAuth, All Rights Reserved
+ * Copyright (c) 2021-2025, FusionAuth, All Rights Reserved
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/main/java/io/fusionauth/http/server/io/HTTPInputStream.java

@@ -194,7 +194,6 @@ private void commit() {
       logger.trace("Client indicated it was sending an entity-body in the request. Handling body using chunked encoding.");
       delegate = new ChunkedInputStream(delegate, 1024, bodyBytes);
       bodyBytes = null;
-      bodyBytesIndex = 0;
 
       if (instrumenter != null) {
         instrumenter.chunkedRequest();

src/main/java/io/fusionauth/http/server/io/HTTPOutputStream.java

@@ -216,7 +216,6 @@ private void commit(boolean closing) throws IOException {
     }
 
     // +++++++++++ Step 2: Write the preamble. This must be first without any other output stream interference +++++++++++
-    // System.out.println("   > HTTPOutputStream commit() -- writeResponsePreamble");
     HTTPTools.writeResponsePreamble(response, delegate);
 
     // +++++++++++ Step 3: Bail if there is no content +++++++++++

src/main/java/io/fusionauth/http/util/BetterByteBuffer.java

@@ -232,6 +232,14 @@ public void beforeMethod() {
     verbose = false;
   }
 
+  @DataProvider
+  public Object[][] connections() {
+    return new Object[][]{
+        {Connections.Close},
+        {Connections.KeepAlive}
+    };
+  }
+
   @AfterMethod
   public void flush() {
     FileLogger fl = (FileLogger) FileLoggerFactory.FACTORY.getLogger(BaseTest.class);
@@ -319,14 +327,6 @@ public Object[][] schemes() {
     };
   }
 
-  @DataProvider
-  public Object[][] connections() {
-    return new Object[][]{
-        {Connections.Close},
-        {Connections.KeepAlive}
-    };
-  }
-
   /**
    * @return The possible response buffer lengths and schemes.
    */
@@ -427,8 +427,7 @@ protected void println(Object o) {
   protected void sleep(long millis) {
     try {
       Thread.sleep(millis);
-    } catch (InterruptedException e) {
-      // Ignore
+    } catch (InterruptedException ignore) {
     }
   }
 

src/test/java/io/fusionauth/http/BaseTest.java

@@ -275,7 +275,7 @@ public void invalid_version() throws Exception {
 
   @Test
   public void keepAlive_bodyNeverRead() throws Exception {
-    // Use case: Using keep alive, and the request handler doesn't ready the payload.
+    // Use case: Using keep alive, and the request handler doesn't read the payload.
     // - Ensure the HTTP worker is able to drain the bytes so the next request starts with an empty byte array.
     withRequest("""
         GET / HTTP/1.1\r

src/test/java/io/fusionauth/http/HTTP11SocketTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022, FusionAuth, All Rights Reserved
+ * Copyright (c) 2022-2025, FusionAuth, All Rights Reserved
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ public class SecurityToolsTest extends BaseTest {
 
   @BeforeClass
   public static void setUp() {
-    projectDir = java.nio.file.Path.of("");
+    projectDir = Path.of("");
   }
 
   @Test