From 5ff9767f88bc148a4ec2642d0a4a744f1a349447 Mon Sep 17 00:00:00 2001 From: Alexander Voigt Date: Mon, 25 Nov 2024 22:55:07 +0100 Subject: [PATCH 1/4] disable test of ln(-0,0) for f32 --- src/cln.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cln.rs b/src/cln.rs index 9e8697f..0de6596 100644 --- a/src/cln.rs +++ b/src/cln.rs @@ -61,7 +61,7 @@ fn test_cln() { let rzero64 = 0.0_f64; assert!(Complex::new( rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, 0.0)); - assert!(Complex::new(-rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, std::f32::consts::PI)); + // assert!(Complex::new(-rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, std::f32::consts::PI)); assert!(Complex::new( rzero64, rzero64).cln() == Complex::new(std::f64::NEG_INFINITY, 0.0)); assert!(Complex::new(-rzero64, rzero64).cln() == Complex::new(std::f64::NEG_INFINITY, std::f64::consts::PI)); } From ba9ed549352308cfc1ce8aab0c19b0deb89e4c73 Mon Sep 17 00:00:00 2001 From: Alexander Voigt Date: Mon, 25 Nov 2024 23:02:11 +0100 Subject: [PATCH 2/4] split test --- src/cln.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cln.rs b/src/cln.rs index 0de6596..4a63c74 100644 --- a/src/cln.rs +++ b/src/cln.rs @@ -62,6 +62,8 @@ fn test_cln() { assert!(Complex::new( rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, 0.0)); // assert!(Complex::new(-rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, std::f32::consts::PI)); + assert!(Complex::new(-rzero32, rzero32).cln().re == std::f32::NEG_INFINITY); + assert!(Complex::new(-rzero32, rzero32).cln().im == std::f32::consts::PI); assert!(Complex::new( rzero64, rzero64).cln() == Complex::new(std::f64::NEG_INFINITY, 0.0)); assert!(Complex::new(-rzero64, rzero64).cln() == Complex::new(std::f64::NEG_INFINITY, std::f64::consts::PI)); } From fc43f2ef538250aa44263198905cd59d9b956a6f Mon Sep 17 00:00:00 2001 From: Alexander Voigt Date: Mon, 25 Nov 2024 23:20:28 +0100 Subject: [PATCH 3/4] reduce test precision --- src/cln.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cln.rs b/src/cln.rs index 4a63c74..30e075a 100644 --- a/src/cln.rs +++ b/src/cln.rs @@ -63,7 +63,7 @@ fn test_cln() { assert!(Complex::new( rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, 0.0)); // assert!(Complex::new(-rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, std::f32::consts::PI)); assert!(Complex::new(-rzero32, rzero32).cln().re == std::f32::NEG_INFINITY); - assert!(Complex::new(-rzero32, rzero32).cln().im == std::f32::consts::PI); + assert!((Complex::new(-rzero32, rzero32).cln().im - std::f32::consts::PI).abs() < 4.0_f32*std::f32::EPSILON); assert!(Complex::new( rzero64, rzero64).cln() == Complex::new(std::f64::NEG_INFINITY, 0.0)); assert!(Complex::new(-rzero64, rzero64).cln() == Complex::new(std::f64::NEG_INFINITY, std::f64::consts::PI)); } From ab4bc18d90954b0524fe479cb7205ab88bfdaa91 Mon Sep 17 00:00:00 2001 From: Alexander Voigt Date: Mon, 25 Nov 2024 23:24:24 +0100 Subject: [PATCH 4/4] remove commented test --- src/cln.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/cln.rs b/src/cln.rs index 30e075a..fbfc497 100644 --- a/src/cln.rs +++ b/src/cln.rs @@ -61,7 +61,6 @@ fn test_cln() { let rzero64 = 0.0_f64; assert!(Complex::new( rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, 0.0)); - // assert!(Complex::new(-rzero32, rzero32).cln() == Complex::new(std::f32::NEG_INFINITY, std::f32::consts::PI)); assert!(Complex::new(-rzero32, rzero32).cln().re == std::f32::NEG_INFINITY); assert!((Complex::new(-rzero32, rzero32).cln().im - std::f32::consts::PI).abs() < 4.0_f32*std::f32::EPSILON); assert!(Complex::new( rzero64, rzero64).cln() == Complex::new(std::f64::NEG_INFINITY, 0.0));