Skip to content

Unnecessary dependency on Serilog.Sinks.XUnit #1

@vitalii-florean

Description

@vitalii-florean

hello Ervin,
we are using IsolatedSqlDb package in our projects, and we noticed that in the package there is unnecessary dependency on Serilog.Sinks.XUnit.

Could you please move the reference to the Serilog.Sinks.XUnit package from the project IsolatedSqlDb.csproj to the test project IsolatedSqlDb.Tests.csproj?

Why I am asking about that?
Because now we are going to upgrade to xUnit v3 and it gives us some troubles having such dependency IsolatedSqlDb -> Serilog.Sinks.XUnit -> XUnit v2.

Thank you in advance,
Vitalii Florean

P.S.
If you would give me permission to the repository, I can make the changes and prepare the pull request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions