Revert the whole pipeline status icons update feature

Author: EpocDotFr

README.md

@@ -21,7 +21,6 @@ A browser extension that enhance all Merge Requests lists on any instance of Git
     - Base Jira URL is configured in extension preferences
     - The ticket ID or an icon can be displayed as the link label (configured in extension preferences)
   - WIP toggle button (can be enabled/disabled in the extension preferences)
-  - Automatic pipeline status update every 10 seconds (can be enabled/disabled in the extension preferences)
   - Compatible with all GitLab editions (GitLab CE, GitLab EE, GitLab.com) (look at the prerequisites, though)
 
 ## Prerequisites
@@ -51,6 +50,10 @@ Due to a technical GitLab limitation, the extension has no reliable way to deter
 
 It would be great, however the extension has no reliable way to do that due to a technical GitLab limitation.
 
+  - Pipeline status icons aren't being automatically updated on Merge Requests lists (it is on other pages), can you add this feature?
+
+That was the initial idea for the 1.6 release, however it's not possible due to a technical GitLab limitation.
+
 ## Changelog
 
 See [here](https://github.com/EpocDotFr/gitlab-merge-requests-lists-enhancer/releases).

html/options.html

@@ -62,17 +62,6 @@
         <div class="pbs pll">
             <small class="txt-muted">This feature is automatically disabled if logged-out</small>
         </div>
-        <div class="pts row">
-            <div class="w40p txt-center browser-style">
-                <input type="checkbox" id="automatically_update_pipeline_status_icons">
-            </div>
-            <div>
-                <label for="automatically_update_pipeline_status_icons">Automatically update pipeline status icons every 10 seconds</label>
-            </div>
-        </div>
-        <div class="pbs pll">
-            <small class="txt-muted">This feature is automatically disabled if the GitLab "pipeline" feature is disabled</small>
-        </div>
         <div class="txt-center pts pbs"><button type="submit" class="browser-style">Save preferences</button></div>
     </form>
 

js/content.js

@@ -132,7 +132,6 @@
             this.baseUrl = location.protocol + '//' + location.host;
             this.baseApiUrl = this.baseUrl + '/api/v4/';
             this.userAuthenticated = this.isUserAuthenticated();
-            this.pipelineFeatureEnabled = this.isPipelineFeatureEnabled();
             this.apiClient = new GitLabApiClient(this.baseApiUrl, this.getCsrfToken());
 
             this.currentMergeRequestIds = this.getCurrentMergeRequestIds();
@@ -185,13 +184,6 @@
             return document.querySelector('.navbar-nav .header-user') ? true : false;
         }
 
-        /**
-         * Determines if the project do uses the Gitlab "pipeline" feature.
-         */
-        isPipelineFeatureEnabled() {
-            return document.querySelector('.issuable-pipeline-status') ? true : false;
-        }
-
         /**
          * Gets all Merge Requests IDs that are currently displayed.
          */
@@ -210,7 +202,10 @@
         fetchMergeRequestsDetailsThenUpdateUI(mergeRequestIds) {
             let self = this;
 
-            this.fetchMergeRequestsDetails(mergeRequestIds).then(function(responseData) {
+            this.apiClient.getProjectMergeRequests(
+                this.currentProjectId,
+                mergeRequestIds
+            ).then(function(responseData) {
                 if (self.preferences.display_source_and_target_branches) {
                     self.removeExistingTargetBranchNodes();
                 }
@@ -228,24 +223,9 @@
                 if (self.userAuthenticated && self.preferences.enable_button_to_toggle_wip_status) {
                     self.attachClickEventToToggleWipStatusButtons();
                 }
-
-                if (self.pipelineFeatureEnabled && self.preferences.automatically_update_pipeline_status_icons) {
-                    self.schedulePipelineStatusIconsUpdate();
-                }
             });
         }
 
-        /**
-         * Performs an HTTP GET request to the GitLab API to retrieve details about Merge Requests that are
-         * currently displayed.
-         */
-        fetchMergeRequestsDetails(mergeRequestIds) {
-            return this.apiClient.getProjectMergeRequests(
-                this.currentProjectId,
-                mergeRequestIds
-            );
-        }
-
         /**
          * Removes all branches that may have been already displayed by GitLab.
          */
@@ -594,34 +574,6 @@
               return placeholders[placeholder];
             }).trim();
         }
-
-        /*
-         * Schedule a pipeline status icons update to be performed in 10 seconds.
-         */
-        schedulePipelineStatusIconsUpdate() {
-            let self = this;
-
-            setTimeout(function() {
-                self.updatePipelineStatusIcons();
-            }, 10000);
-        }
-
-        /**
-         * Actually update pipeline status icons by invoking the GitLab API.
-         */
-        updatePipelineStatusIcons() {
-            let self = this;
-
-            this.fetchMergeRequestsDetails(this.currentMergeRequestIds).then(function(mergeRequests) {
-                mergeRequests.forEach(function(mergeRequest) {
-                    let mergeRequestNode = self.getMergeRequestNode(mergeRequest.id);
-
-                    // TODO
-                });
-
-                self.schedulePipelineStatusIconsUpdate();
-            });
-        }
     }
 
     let cs = new ContentScript();

js/options.js

@@ -37,8 +37,6 @@
             this.jiraTicketLinkLabelTypeRadioButtons = Array.from(document.querySelectorAll('input[name="jira_ticket_link_label_type"]'));
 
             this.enableButtonToToggleWipStatusCheckbox = document.querySelector('input#enable_button_to_toggle_wip_status');
-
-            this.automaticallyUpdatePipelineStatusIconsCheckbox = document.querySelector('input#automatically_update_pipeline_status_icons');
         }
 
         /**
@@ -69,9 +67,6 @@
 
                 self.enableButtonToToggleWipStatusCheckbox.checked = preferences.enable_button_to_toggle_wip_status;
                 self.enableButtonToToggleWipStatusCheckbox.dispatchEvent(new CustomEvent('change'));
-
-                self.automaticallyUpdatePipelineStatusIconsCheckbox.checked = preferences.automatically_update_pipeline_status_icons;
-                self.automaticallyUpdatePipelineStatusIconsCheckbox.dispatchEvent(new CustomEvent('change'));
             });
         }
 
@@ -122,10 +117,6 @@
             this.enableButtonToToggleWipStatusCheckbox.addEventListener('change', function() {
                 self.forceUserToEnableAtLeastOneFeatureIfNecessarily();
             });
-
-            this.automaticallyUpdatePipelineStatusIconsCheckbox.addEventListener('change', function() {
-                self.forceUserToEnableAtLeastOneFeatureIfNecessarily();
-            });
         }
 
         /**
@@ -147,8 +138,7 @@
                     enable_jira_ticket_link: this.enableJiraTicketLinkCheckbox.checked,
                     base_jira_url: this.baseJiraUrlInput.value,
                     jira_ticket_link_label_type: jira_ticket_link_label_type,
-                    enable_button_to_toggle_wip_status: this.enableButtonToToggleWipStatusCheckbox.checked,
-                    automatically_update_pipeline_status_icons: this.automaticallyUpdatePipelineStatusIconsCheckbox.checked
+                    enable_button_to_toggle_wip_status: this.enableButtonToToggleWipStatusCheckbox.checked
                 },
                 function() {
                     self.setSuccessfulVisualFeedbackOnSubmitButton();
@@ -183,8 +173,7 @@
             return !this.displaySourceAndTargetBranchesCheckbox.checked
                 && !this.enableButtonToCopyMrInfoCheckbox.checked
                 && !this.enableJiraTicketLinkCheckbox.checked
-                && !this.enableButtonToToggleWipStatusCheckbox.checked
-                && !this.automaticallyUpdatePipelineStatusIconsCheckbox.checked;
+                && !this.enableButtonToToggleWipStatusCheckbox.checked;
         }
 
         /**

js/preferences.js

@@ -13,8 +13,7 @@
                 enable_jira_ticket_link: false,
                 base_jira_url: '',
                 jira_ticket_link_label_type: 'ticket_id',
-                enable_button_to_toggle_wip_status: true,
-                automatically_update_pipeline_status_icons: false
+                enable_button_to_toggle_wip_status: true
             };
         }