Skip to content

Commit a9e8906

Browse files
authored
[REVERTME] Change disable_auto_batching_passes default to true (#1979)
1 parent 095de03 commit a9e8906

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

docs/src/tutorials/raising.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,13 @@ raising).
128128
```
129129

130130
This IR has a nested loop, but that won't work nicely for GPUs/TPUs. Even for CPUs, XLA
131-
often doens't do a great job with loops. By default, we will attempt to raise loops to a
131+
often doens't do a great job with loops. We will attempt to raise loops to a
132132
tensor IR.
133133

134134
```@example raising_stablehlo
135-
hlo = @code_hlo compute_attractive_force(positions_ra, masses_ra, 2.0f0)
135+
hlo = @code_hlo compile_options=CompileOptions(;
136+
disable_auto_batching_passes=false
137+
) compute_attractive_force(positions_ra, masses_ra, 2.0f0)
136138
@assert !contains(repr(hlo), "stablehlo.while") #hide
137139
hlo
138140
```
@@ -142,7 +144,9 @@ the values are identical.
142144

143145
```@example raising_stablehlo
144146
y_jl = compute_attractive_force(positions, masses, 2.0f0)
145-
y_ra = @jit compute_attractive_force(positions_ra, masses_ra, 2.0f0)
147+
y_ra = @jit compile_options=CompileOptions(;
148+
disable_auto_batching_passes=false
149+
) compute_attractive_force(positions_ra, masses_ra, 2.0f0)
146150
maximum(abs, Array(y_ra) .- y_jl)
147151
```
148152

src/CompileOptions.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ function CompileOptions(;
212212
disable_scatter_gather_optimization_passes::Bool=false,
213213
disable_pad_optimization_passes::Bool=false,
214214
disable_licm_optimization_passes::Bool=false,
215-
disable_auto_batching_passes::Bool=false,
215+
disable_auto_batching_passes::Bool=true,
216216
)
217217
optimization_passes isa Bool &&
218218
(optimization_passes = ifelse(optimization_passes, :all, :none))

0 commit comments

Comments
 (0)