-
Notifications
You must be signed in to change notification settings - Fork 1
Description
-
Right now there is a hardcoded approach to prioritising appraisals with equally-good metrics in
AppraisalOutput::compare_with_equal_metrics.We may want to make this configurable -
If we still can't single out a single-best appraisal we always pick the first element in the container in
select_from_assets_with_equal_metric. We may also want to make this configurable -
It might make more sense to remove the call to
AppraisalOutput::compare_with_equal_metricsinAppraisalOutput::compare_metricand independently sort by the equal-metric criteria inselect_from_assets_with_equal_metricinstead of relying on the initial sort withcompare_metric. -
Since the rules are getting more complex might be nice to have add testing for this functionality with an array of appraisals as a fixture which checks the asset we expect is chosen
Metadata
Metadata
Assignees
Labels
Type
Projects
Status