fix some ptr issues

Author: Hugobros3

src/shady/emit/c/emit_c_instructions.c

@@ -349,7 +349,7 @@ static void emit_primop(Emitter* emitter, Printer* p, const Node* node, Instruct
                 // this means such code is never going to be legal in GLSL
                 // also the cast is to account for our arrays-in-structs hack
                 const Type* pointee_type = get_pointee_type(arena, curr_ptr_type);
-                acc = term_from_cvalue(format_string_arena(arena->arena, "((%s) &%s)", emit_type(emitter, curr_ptr_type, NULL), index_into_array(emitter, pointee_type, acc, offset)));
+                acc = term_from_cvalue(format_string_arena(arena->arena, "((%s) &(%s)[%s])", emit_type(emitter, curr_ptr_type, NULL), to_cvalue(emitter, acc), to_cvalue(emitter, offset)));
                 uniform &= is_qualified_type_uniform(prim_op->operands.nodes[1]->type);
             }
 

src/shady/passes/opt_mem2reg.c

@@ -352,6 +352,9 @@ static const Node* process_instruction(Context* ctx, KnowledgeBase* kb, const No
                     // }
                     return prim_op_helper(a, load_op, empty(a), singleton(rewrite_node(r, optr)));
                 }
+                // case memcpy_op: {
+                //     const Node* optr = first(payload.operands);
+                // }
                 case store_op: {
                     const Node* optr = first(payload.operands);
                     PtrKnowledge* k = find_or_create_ptr_knowledge_for_updating(ctx, kb, optr, true);

src/shady/type.c

@@ -802,6 +802,7 @@ const Type* check_type_prim_op(IrArena* arena, PrimOp prim_op) {
             const IntLiteral* lit = resolve_to_int_literal(offset);
             bool offset_is_zero = lit && lit->value == 0;
             assert(offset_is_zero || !base_ptr_type->payload.ptr_type.is_reference && "if an offset is used, the base cannot be a reference");
+            assert(offset_is_zero || is_data_type(pointee_type) && "if an offset is used, the base must point to a data type");
             uniform &= offset_uniform;
 
             Nodes indices = nodes(arena, prim_op.operands.count - 2, &prim_op.operands.nodes[2]);
@@ -1036,7 +1037,7 @@ const Type* check_type_prim_op(IrArena* arena, PrimOp prim_op) {
         case get_stack_base_op: {
             assert(prim_op.type_arguments.count == 0);
             assert(prim_op.operands.count == 0);
-            const Node* ptr = ptr_type(arena, (PtrType) { .pointed_type = arr_type(arena, (ArrType) { .element_type = uint8_type(arena), .size = NULL }), .address_space = AsPrivate});
+            const Node* ptr = ptr_type(arena, (PtrType) { .pointed_type = uint8_type(arena), .address_space = AsPrivate});
             return qualified_type(arena, (QualifiedType) { .is_uniform = false, .type = ptr });
         }
         case set_stack_pointer_op: {