feat: Change extra_body_parameters to override normal parameters

Author: JanEbbing

deepl/translator.py

@@ -476,8 +476,6 @@ def join_tags(tag_argument: Union[str, Iterable[str]]) -> List[str]:
         # Do not overwrite keys that were explicitly set by this method.
         if extra_body_parameters:
             for k, v in extra_body_parameters.items():
-                if k in request_data:
-                    continue
                 request_data[k] = v
 
         status, content, json = self._api_call(
@@ -761,8 +759,6 @@ def translate_document_upload(
             files = {"file": input_document}
         if extra_body_parameters:
             for k, v in extra_body_parameters.items():
-                if k in request_data:
-                    continue
                 request_data[k] = v
 
         status, content, json = self._api_call(

tests/test_translate_text.py

@@ -406,7 +406,7 @@ def test_mixed_case_languages(translator):
 
 
 def test_extra_body_params(translator):
-    # Checks `target_lang` is not overwritten, does not check
+    # Checks `target_lang` is overwritten, does not check
     # debug is actually sent
     extra = {"target_lang": "FR", "debug": "1"}
     res = translator.translate_text(
@@ -415,6 +415,6 @@ def test_extra_body_params(translator):
         extra_body_parameters=extra,
     )
     assert isinstance(res, deepl.TextResult)
-    assert example_text["DE"] == res.text
+    assert example_text["FR"] == res.text
     assert "EN" == res.detected_source_lang
     assert res.billed_characters == len(example_text["EN"])