Fix bug where updating archive cvars sometimes does not write autogen.cfg #1876
+6
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the pointless `int flags` argument to Cvar::InternalSetValue which is always 0.
A command such as /set common.framerate.max 99, when the cvar was previously marked as archive, could fail to cause the configuration file to be written out. This happened because the code relied on the flags field of the C API cvar_t object to detect updates, but Cvar::AddFlags failed to update cvar_t. Note that setting cvars in the UI was not affected because the UI re-adds the archive flag every time and the act of adding the flag triggers an update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example if you do
/seta common.framerate.max 30then/set common.framerate.max 31, the second command does not write out the cvars although it should since it still has the archive flag added by the first.