codereview

Author: dapeng

cassandra/cassandra-side/cassandra-side-core/src/main/java/com/dtstack/flink/sql/side/cassandra/table/CassandraSideParser.java

@@ -99,6 +99,7 @@ public TableInfo getTableInfo(String tableName, String fieldsInfo, Map<String, O
     private void dealSideSign(Matcher matcher, TableInfo tableInfo) {
     }
 
+    @Override
     public Class dbTypeConvertToJavaType(String fieldType) {
         switch (fieldType.toLowerCase()) {
             case "bigint":
@@ -121,6 +122,8 @@ public Class dbTypeConvertToJavaType(String fieldType) {
                 return Double.class;
             case "timestamp":
                 return Timestamp.class;
+            default:
+                break;
         }
 
         throw new RuntimeException("不支持 " + fieldType + " 类型");

clickhouse/clickhouse-side/clickhouse-all-side/src/main/java/com/dtstack/flink/sql/side/clickhouse/ClickhouseAllReqRow.java

@@ -42,15 +42,15 @@ public ClickhouseAllReqRow(RowTypeInfo rowTypeInfo, JoinInfo joinInfo, List<Fiel
     }
 
     @Override
-    public Connection getConn(String dbURL, String userName, String passWord) {
+    public Connection getConn(String dbUrl, String userName, String passWord) {
         try {
             Connection connection ;
             JDBCUtils.forName(CLICKHOUSE_DRIVER, getClass().getClassLoader());
             // ClickHouseProperties contains all properties
             if (userName == null) {
-                connection = DriverManager.getConnection(dbURL);
+                connection = DriverManager.getConnection(dbUrl);
             } else {
-                connection = DriverManager.getConnection(dbURL, userName, passWord);
+                connection = DriverManager.getConnection(dbUrl, userName, passWord);
             }
             return connection;
         } catch (Exception e) {

console/console-sink/src/main/java/com/dtstack/flink/sql/sink/console/table/TablePrintUtil.java

@@ -119,7 +119,7 @@ private static List<Col> getColList(Object obj) {
         Method[] methods = obj.getClass().getMethods();
         for (Method m : methods) {
             StringBuilder getMethodName = new StringBuilder(m.getName());
-            if (getMethodName.substring(0, 3).equals("get") && !m.getName().equals("getClass")) {
+            if ("get".equals(getMethodName.substring(0, 3)) && !"getClass".equals(m.getName())) {
                 Col col = new Col();
                 col.getMethodName = getMethodName.toString();
                 char first = Character.toLowerCase(getMethodName.delete(0, 3).charAt(0));