Skip to content

Commit 97ce51b

Browse files
增加一些注释
1 parent 94e8a0b commit 97ce51b

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

elasticsearch6/elasticsearch6-side/elasticsearch6-all-side/src/main/java/com/dtstack/flink/sql/side/elasticsearch6/Elasticsearch6AllReqRow.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ protected void initCache() throws SQLException {
159159
Map<String, List<Map<String, Object>>> newCache = Maps.newConcurrentMap();
160160
cacheRef.set(newCache);
161161
try {
162-
// create search request and build where cause
163162
searchRequest = Es6Util.setSearchRequest(sideInfo);
164163
boolQueryBuilder = Es6Util.setPredicateclause(sideInfo);
165164
loadData(newCache);
@@ -218,7 +217,6 @@ private void loadData(Map<String, List<Map<String, Object>>> tmpCache) throws IO
218217
}
219218
}
220219

221-
// initialize searchSourceBuilder
222220
private SearchSourceBuilder initConfiguration(BoolQueryBuilder boolQueryBuilder){
223221
SearchSourceBuilder searchSourceBuilder = new SearchSourceBuilder();
224222
if (boolQueryBuilder != null) {
@@ -227,8 +225,6 @@ private SearchSourceBuilder initConfiguration(BoolQueryBuilder boolQueryBuilder)
227225

228226
searchSourceBuilder.size(getFetchSize());
229227
searchSourceBuilder.sort("_id", SortOrder.DESC);
230-
231-
// fields included in the source data
232228
String[] sideFieldNames = StringUtils.split(sideInfo.getSideSelectFields().trim(), ",");
233229
searchSourceBuilder.fetchSource(sideFieldNames, null);
234230
return searchSourceBuilder;
@@ -244,7 +240,6 @@ private void searchData(SearchSourceBuilder searchSourceBuilder, Map<String, Lis
244240
while (true) {
245241
try {
246242
if (searchAfterParameter != null) {
247-
// set search mark
248243
searchSourceBuilder.searchAfter(searchAfterParameter);
249244
}
250245
searchRequest.source(searchSourceBuilder);
@@ -263,7 +258,6 @@ private void searchData(SearchSourceBuilder searchSourceBuilder, Map<String, Lis
263258
}
264259
}
265260

266-
// data load to cache
267261
private void loadToCache(SearchHit[] searchHits, Map<String, List<Map<String, Object>>> tmpCache) {
268262
String[] sideFieldNames = StringUtils.split(sideInfo.getSideSelectFields().trim(), ",");
269263
String[] sideFieldTypes = sideInfo.getSideTableInfo().getFieldTypes();

elasticsearch6/elasticsearch6-side/elasticsearch6-async-side/src/main/java/com/dtstack/flink/sql/side/elasticsearch6/Elasticsearch6AsyncReqRow.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,10 @@ public void onResponse(SearchResponse searchResponse) {
136136
try {
137137
while (true) {
138138
loadDataToCache(searchHits, rowList, cacheContent, copyCrow);
139-
// determine if all results haven been ferched
140139
if (searchHits.length < getFetchSize()) {
141140
break;
142141
}
143142
if (tableInfo == null && tmpRhlClient == null) {
144-
// create new connection to fetch data
145143
tableInfo = (Elasticsearch6SideTableInfo) sideInfo.getSideTableInfo();
146144
tmpRhlClient = Es6Util.getClient(tableInfo.getAddress(), tableInfo.isAuthMesh(), tableInfo.getUserName(), tableInfo.getPassword());
147145
}
@@ -189,6 +187,7 @@ private void loadDataToCache(SearchHit[] searchHits, List<CRow> rowList, List<Ob
189187
rowList.addAll(getRows(copyCrow, cacheContent, results));
190188
}
191189

190+
192191
protected List<CRow> getRows(CRow inputRow, List<Object> cacheContent, List<Object> results) {
193192
List<CRow> rowList = Lists.newArrayList();
194193
for (Object line : results) {
@@ -258,6 +257,7 @@ private SearchSourceBuilder initConfiguration() {
258257
return searchSourceBuilder;
259258
}
260259

260+
261261
private BoolQueryBuilder setInputParams(List<Object> inputParams, BoolQueryBuilder boolQueryBuilder) {
262262
if (boolQueryBuilder == null) {
263263
boolQueryBuilder = new BoolQueryBuilder();
@@ -273,6 +273,7 @@ private BoolQueryBuilder setInputParams(List<Object> inputParams, BoolQueryBuild
273273
return boolQueryBuilder;
274274
}
275275

276+
276277
public int getFetchSize() {
277278
return 1000;
278279
}

elasticsearch6/elasticsearch6-side/elasticsearch6-side-core/src/main/java/com/dtstack/flink/sql/side/elasticsearch6/util/Es6Util.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ public class Es6Util {
5151
private static final String KEY_WORD_TYPE = ".keyword";
5252
private static final String APOSTROPHE = "\'";
5353

54-
// connect to the elasticsearch
5554
public static RestHighLevelClient getClient(String esAddress, Boolean isAuthMesh, String userName, String password) {
5655
List<HttpHost> httpHostList = new ArrayList<>();
5756
String[] address = StringUtils.split(esAddress, ",");
@@ -97,7 +96,6 @@ public static RestHighLevelClient getClient(String esAddress, Boolean isAuthMesh
9796
return rhlClient;
9897
}
9998

100-
// add index and type to search request
10199
public static SearchRequest setSearchRequest(SideInfo sideInfo) {
102100
SearchRequest searchRequest = new SearchRequest();
103101
Elasticsearch6SideTableInfo tableInfo = (Elasticsearch6SideTableInfo) sideInfo.getSideTableInfo();
@@ -128,7 +126,6 @@ public static SearchRequest setSearchRequest(SideInfo sideInfo) {
128126
return searchRequest;
129127
}
130128

131-
// build where cause
132129
public static BoolQueryBuilder setPredicateclause(SideInfo sideInfo) {
133130

134131
BoolQueryBuilder boolQueryBuilder = null;
@@ -143,7 +140,6 @@ public static BoolQueryBuilder setPredicateclause(SideInfo sideInfo) {
143140
return boolQueryBuilder;
144141
}
145142

146-
// build filter condition
147143
public static BoolQueryBuilder buildFilterCondition(BoolQueryBuilder boolQueryBuilder, PredicateInfo info, SideInfo sideInfo) {
148144
switch (info.getOperatorKind()) {
149145
case "IN":
@@ -188,7 +184,6 @@ public static BoolQueryBuilder buildFilterCondition(BoolQueryBuilder boolQueryBu
188184

189185
}
190186

191-
// remove extra spaces and apostrophes
192187
public static String[] removeSpaceAndApostrophe(String str) {
193188
String[] split = StringUtils.split(str, ",");
194189
for (int i = 0; i < split.length; i++) {
@@ -201,7 +196,6 @@ public static String[] removeSpaceAndApostrophe(String str) {
201196
return split;
202197
}
203198

204-
// prevent word segmentation
205199
public static String textConvertToKeyword(String fieldName, SideInfo sideInfo) {
206200
String[] sideFieldTypes = sideInfo.getSideTableInfo().getFieldTypes();
207201
int fieldIndex = sideInfo.getSideTableInfo().getFieldList().indexOf(fieldName.trim());

0 commit comments

Comments
 (0)