修复sonar扫描的问题

dapeng · dapeng · commit 03a491311e6f · 2020-04-08T17:38:59.000+08:00
diff --git a/hbase/hbase-side/hbase-side-core/src/main/java/com/dtstack/flink/sql/side/hbase/RowKeyBuilder.java b/hbase/hbase-side/hbase-side-core/src/main/java/com/dtstack/flink/sql/side/hbase/RowKeyBuilder.java
@@ -121,7 +121,7 @@ public ReplaceInfo getReplaceInfo(String field){
 
     private List<ReplaceInfo> makeFormula(String formula){
         if(formula == null || formula.length() <= 0){
-            Lists.newArrayList();
+            return Lists.newArrayList();
         }
         List<ReplaceInfo> result = Lists.newArrayList();
         for(String meta: splitIgnoreQuotaBrackets(formula, "\\+")){
diff --git a/hbase/hbase-sink/src/main/java/com/dtstack/flink/sql/sink/hbase/HbaseOutputFormat.java b/hbase/hbase-sink/src/main/java/com/dtstack/flink/sql/sink/hbase/HbaseOutputFormat.java
@@ -22,7 +22,6 @@
 
 import com.dtstack.flink.sql.enums.EUpdateMode;
 import com.dtstack.flink.sql.outputformat.AbstractDtRichOutputFormat;
-import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.flink.api.java.tuple.Tuple2;
@@ -41,7 +40,6 @@
 import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
-import java.util.List;
 import java.util.Map;
 import java.util.Set;
 
diff --git a/hbase/hbase-sink/src/main/java/com/dtstack/flink/sql/sink/hbase/RowKeyBuilder.java b/hbase/hbase-sink/src/main/java/com/dtstack/flink/sql/sink/hbase/RowKeyBuilder.java
@@ -130,7 +130,7 @@ public ReplaceInfo getReplaceInfo(String field){
 
     private List<ReplaceInfo> makeFormula(String formula){
         if(formula == null || formula.length() <= 0){
-            Lists.newArrayList();
+            return Lists.newArrayList();
         }
         List<ReplaceInfo> result = Lists.newArrayList();
         for(String meta: splitIgnoreQuotaBrackets(formula, "\\+")){

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public ReplaceInfo getReplaceInfo(String field){`
`121`	`121`
`122`	`122`	`private List<ReplaceInfo> makeFormula(String formula){`
`123`	`123`	`if(formula == null \|\| formula.length() <= 0){`
`124`		`- Lists.newArrayList();`
	`124`	`+ return Lists.newArrayList();`
`125`	`125`	`}`
`126`	`126`	`List<ReplaceInfo> result = Lists.newArrayList();`
`127`	`127`	`for(String meta: splitIgnoreQuotaBrackets(formula, "\\+")){`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ public ReplaceInfo getReplaceInfo(String field){`
`130`	`130`
`131`	`131`	`private List<ReplaceInfo> makeFormula(String formula){`
`132`	`132`	`if(formula == null \|\| formula.length() <= 0){`
`133`		`- Lists.newArrayList();`
	`133`	`+ return Lists.newArrayList();`
`134`	`134`	`}`
`135`	`135`	`List<ReplaceInfo> result = Lists.newArrayList();`
`136`	`136`	`for(String meta: splitIgnoreQuotaBrackets(formula, "\\+")){`