Skip to content

Fix ci phpcscompat upgrades #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vmcj wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix ci phpcscompat upgrades #3275

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e9554c
Temporary ugly fix
vmcj Dec 1, 2025
ba1b426
Let the container fix itself
vmcj Dec 1, 2025
c3c6d47
And disable the problematic replacement
vmcj Dec 1, 2025
8fbb6ea
Explain the reasoning
vmcj Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/jobs/fix_pipelinecomponents_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ mydir=$(pwd)
echo "Before /app/composer.json:"
cat /app/composer.json
sed -i 's/"phpcompatibility\/php-compatibility": "9.3.5"/"phpcompatibility\/php-compatibility": "dev-develop"/g' /app/composer.json
sed -i 's/"squizlabs\/php_codesniffer": "3.13.2"/"squizlabs\/php_codesniffer": "^3.13.3"/g' /app/composer.json
sed -i 's/"squizlabs\/php_codesniffer": "3.13.2"/"squizlabs\/php_codesniffer": "^4.0.1"/g' /app/composer.json
echo "After /app/composer.json:"
cat /app/composer.json

cd /app; composer update
cd /app; composer -W update
Copy link
Member

@meisterT meisterT Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding an explanatory comment before this line so that we know why we added -W (or why we need to run composer update at all)

Copy link
Member Author

@vmcj vmcj Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the problem I'll probably add a proper fix so we don't need this at all.

If/when this works I think I remove the test completely and let our CI container install this tool to (re)move the ugliness to the scripts repo.

cd $mydir
Loading