From 9dcbdfb462529fde7d14ab0c67206bab48d3dbbe Mon Sep 17 00:00:00 2001
From: MCJ Vasseur <14887731+vmcj@users.noreply.github.com>
Date: Mon, 1 Dec 2025 10:13:07 +0100
Subject: [PATCH] Only show compile if the judging is done

Based on https://domjudge.sentry.io/issues/7076103482/?project=4510437648695296&query=is%3Aunresolved&referrer=issue-stream
---
 webapp/src/Controller/Team/SubmissionController.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/webapp/src/Controller/Team/SubmissionController.php b/webapp/src/Controller/Team/SubmissionController.php
index 9957883054..fad6f33961 100644
--- a/webapp/src/Controller/Team/SubmissionController.php
+++ b/webapp/src/Controller/Team/SubmissionController.php
@@ -150,7 +150,7 @@ public function viewAction(Request $request, int $submitId): Response
         }
 
         $runs = [];
-        if ($showSampleOutput && $judging && $judging->getResult() !== 'compiler-error') {
+        if ($showSampleOutput && $judging?->getResult() !== 'compiler-error') {
             $outputDisplayLimit    = (int)$this->config->get('output_display_limit');
             $outputTruncateMessage = sprintf("\n[output display truncated after %d B]\n", $outputDisplayLimit);
 
@@ -192,7 +192,7 @@ public function viewAction(Request $request, int $submitId): Response
         }
 
         $actuallyShowCompile = $showCompile == self::ALWAYS_SHOW_COMPILE_OUTPUT
-            || ($showCompile == self::ONLY_SHOW_COMPILE_OUTPUT_ON_ERROR && $judging->getResult() === 'compiler-error');
+            || ($showCompile == self::ONLY_SHOW_COMPILE_OUTPUT_ON_ERROR && $judging?->getResult() === 'compiler-error');
 
         $data = [
             'judging' => $judging,