Don't display contest time from before/after contest

It looks ugly in some cases and less professional in others where printing
happened much earlier. The exact time is not relevant and could lead to
discussions with teams.

Originally this was only for the team interface but it does add information for
the jury. It's more important to know that something happened before the
contest (or after) and the interpretation of that time as knowing when it
exactly happened.

We still do this in case we explicit set the format such as for the countdown
etc.

Author: vmcj

webapp/src/Twig/TwigExtension.php

@@ -205,14 +205,24 @@ public function printelapsedminutes(float $start, float $end): string
     /**
      * Print a time formatted as specified. The format is according to date().
      * @param Contest|null $contest If given, print time relative to that contest start.
+     * @param bool $maskOutsideContest When true and contest is given replace time with before/after.
      */
-    public function printtime(string|float|null $datetime, ?string $format = null, ?Contest $contest = null): string
+    public function printtime(string|float|null $datetime, ?string $format = null, ?Contest $contest = null, bool $maskOutsideContest = true): string
     {
         if ($datetime === null) {
             $datetime = Utils::now();
         }
         if ($contest !== null && $this->config->get('show_relative_time')) {
             $relativeTime = $contest->getContestTime((float)$datetime);
+            if ($maskOutsideContest) {
+                if ($relativeTime < 0) {
+                    return "Before contest";
+                }
+                if ($relativeTime > $contest->getContestTime($contest->getEndtime())) {
+                    // The case where it would be exactly at EndTime is important to display
+                    return "After contest";
+                }
+            }
             $sign         = ($relativeTime < 0 ? -1 : 1);
             $relativeTime *= $sign;
             // We're not showing seconds, while the last minute before

webapp/templates/partials/problem_list.html.twig

@@ -105,7 +105,7 @@
                                                                 data-bs-toggle="tooltip"
                                                                 data-bs-placement="top"
                                                                 data-bs-html="true"
-                                                                title="Between {{ stat.start.timestamp | printtime(null, contest) }} and {{ stat.end.timestamp | printtime(null, contest) }}:<br/>{{ label }}">
+                                                                title="Between {{ stat.start.timestamp | printtime(null, contest, false) }} and {{ stat.end.timestamp | printtime(null, contest, false) }}:<br/>{{ label }}">
                                                             </div>
                                                         {% endfor %}
                                                     </div>