Commit 6820633
authored
fix: preserve Vue node reactivity during undo/redo operations (#7222)
## Summary
preserve Vue node reactivity during undo/redo operations
Root Cause: The Vue reactivity chain was broken during undo/redo
operations:
1. handleDeleteNode was deleting nodeRefs and nodeTriggers
2. Vue components still held references to the old refs
3. When nodes were recreated, finalizeOperation tried to call triggers
but they were already deleted
4. Vue didn't know the data had changed, so nodes didn't visually update
fix #7040
## Screenshots
https://github.com/user-attachments/assets/2feb294a-36e8-4bbe-b3f7-b7015066abc5
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7222-fix-preserve-Vue-node-reactivity-during-undo-redo-operations-2c36d73d3650819ab72afb10cbdaf39a)
by [Unito](https://www.unito.io)1 parent 8c5584c commit 6820633
File tree
2 files changed
+26
-5
lines changed- src/renderer
- core/layout/store
- extensions/vueNodes/layout
2 files changed
+26
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
956 | 956 | | |
957 | 957 | | |
958 | 958 | | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
959 | 968 | | |
960 | 969 | | |
961 | 970 | | |
| |||
964 | 973 | | |
965 | 974 | | |
966 | 975 | | |
967 | | - | |
968 | | - | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
969 | 980 | | |
970 | 981 | | |
971 | 982 | | |
| |||
995 | 1006 | | |
996 | 1007 | | |
997 | 1008 | | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
998 | 1012 | | |
999 | 1013 | | |
1000 | 1014 | | |
| |||
1085 | 1099 | | |
1086 | 1100 | | |
1087 | 1101 | | |
1088 | | - | |
1089 | | - | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
1090 | 1106 | | |
1091 | 1107 | | |
1092 | 1108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
20 | 25 | | |
21 | 26 | | |
22 | 27 | | |
| |||
0 commit comments